Add PyUnstable_TryIncref and PyUnstable_EnableTryIncRef. #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Nov 5, 2025
tests/test_pythoncapi_compat_cext.c
Outdated
| return -1; | ||
| } | ||
| #endif | ||
| MyType.tp_name = "MyType"; |
Member
There was a problem hiding this comment.
Can you please use a less generic name, such as TryIncrefType? (for the variable name and the type name)
Member
|
I'm fine with adding these two functions. I just have some suggestions on the implementation. |
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
reviewed
Nov 5, 2025
tests/test_pythoncapi_compat_cext.c
Outdated
| static int MyObject_dealloc_called = 0; | ||
|
|
||
| static void | ||
| MyObject_dealloc(PyObject *op) |
Member
There was a problem hiding this comment.
Would you mind to rename it to TryIncref_dealloc() and rename also MyObject_dealloc_called?
Member
|
Merged, thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These would be useful in PyTorch, which uses pythoncapi-compat.h. They are also already used in pybind11, which doesn't use pythoncapi-compat.h.