Skip to content

macOS: Fix test_pythoninfo.GetInfoTests, stop marking as experimental #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

macOS: Fix test_pythoninfo.GetInfoTests, stop marking as experimental #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5887083
os.path.realpath venv root
maurycy Oct 24, 2025
a5233f6
rm experimental from macos
maurycy Oct 24, 2025
983903c
rm experimental from macos
maurycy Oct 24, 2025
666225a
this?
maurycy Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
experimental: false
- os: macos-latest
python: "3.14"
experimental: true
experimental: false
- os: windows-latest
python: "3.14"
experimental: false
Expand Down
3 changes: 2 additions & 1 deletion pyperformance/tests/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ def cleanup():
onfail="raise",
verbose=verbose,
)
return root, _resolve_venv_python(root), cleanup
venv_root = os.path.realpath(root)
return venv_root, _resolve_venv_python(venv_root), cleanup


class CleanupFile:
Expand Down
5 changes: 3 additions & 2 deletions pyperformance/tests/test_pythoninfo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@
from pyperformance import _pythoninfo, tests

IS_VENV = sys.prefix != sys.base_prefix
_BASE_EXECUTABLE = getattr(sys, "_base_executable", None)
CURRENT = {
"executable (sys)": sys.executable,
"executable (sys;realpath)": os.path.realpath(sys.executable),
"base_executable": sys.executable,
"base_executable (sys)": getattr(sys, "_base_executable", None),
"base_executable": _BASE_EXECUTABLE or sys.executable,
Copy link
Contributor Author

@maurycy maurycy Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyperformance/pyperformance/_pythoninfo.py

Lines 84 to 92 in 74a5b03

base_executable = getattr(sys, "_base_executable", None)
if is_venv:
# XXX There is probably a bug related to venv, since
# sys._base_executable should be different.
if base_executable == sys.executable:
# Indicate that we don't know.
base_executable = None
elif not base_executable:
base_executable = sys.executable

"base_executable (sys)": _BASE_EXECUTABLE,
"version_str (sys)": sys.version,
"version_info (sys)": sys.version_info,
"hexversion (sys)": sys.hexversion,
Expand Down
Loading