gh-141169: Clear error before trying again #141206
Open
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DinoV
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
vstinner
approved these changes
Nov 8, 2025
Comment on lines
+416
to
418
| } else if (PyErr_Occurred()) { | ||
| PyErr_Clear(); | ||
| } |
Member
There was a problem hiding this comment.
No need to check for PyErr_Occurred():
Suggested change
| } else if (PyErr_Occurred()) { | |
| PyErr_Clear(); | |
| } | |
| } | |
| PyErr_Clear(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the issue - we can end up making a call with an error already set when switching from export_prefix to init_prefix - one possible solution is to just clear the error. In this case both calls are failing due to the dlopen failing. I'm not exactly sure how to add a test case for this though.
!_PyErr_Occurred(tstate)error #141169