-
Notifications
You must be signed in to change notification settings - Fork 150
Added base Conda environment yml file #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c65bc11
Added base Conda environment yml file
jdye64 bd37646
Added docs requirements to conda environment file
jdye64 4d15337
Removed cython from conda environment file as it was left their by mi…
jdye64 1fa1fb4
Configured Travis CI to use the new conda environment file instead of…
jdye64 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # Contributing to Streamz | ||
|
|
||
| ## Streamz Conda Environment | ||
| For the convenience of the community streamz offers an environment file for contributors to create conda environments. A few basic quick start commands for creating a using a streamz conda environment are found below. | ||
|
|
||
| ### Creating Conda Development Environment | ||
| Creating the streamz conda environment can be achieved by simply running ```conda env create -f ./conda/environments/streamz_dev.yml``` | ||
|
|
||
| ### Using Conda Environment | ||
| The streamz conda environment can be activated by running ```conda activate streamz_dev``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| name: streamz_dev | ||
| channels: | ||
| - conda-forge | ||
| - defaults | ||
| dependencies: | ||
| - python>=3.7 | ||
| - cython>=0.29,<0.30 | ||
| - pytest | ||
| - flake8 | ||
| - black | ||
| - isort | ||
| - tornado | ||
| - toolz | ||
| - zict | ||
| - six | ||
| - librdkafka=1.2.2 | ||
| - dask | ||
| - distributed | ||
| - pandas | ||
| - python-confluent-kafka=1.1.0 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the cython dep coming from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cytoolz? I don't suppose we're building anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, if one of the deps needs it conda should figure that out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh ... my bad I meant to remove that. I was experimenting with implementing librdkafka with cython and forgot to remove it. I will remove them now.
On a side note that is working very well BTW and might open something up around that as well. Working on the best way to make cython not a hard dependency at the moment since I'm sure several people don't using streamz don't necessarily want it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically you can include the C file for those that want to compile (source dist) and of course, if you build wheels and conda packages, those should not need cython.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused, do you mean that you are using librdkafka with cython or using cython to speed up
streamzkafka bindings?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually both. I was replacing the current streamz kafka sources/bindsings with my own sources (AKA: not the confluent-python-kafka library) which were cython modules that interacted directly with librdkafka++. There are many advantages to that especially in the realm of partition balancing that the new KafkaConsumer offers (not implemented in the confluent python library yet) for distributed systems with many processes appearing/disappearing. I actually saw this #233 while messing around with it and think it could be helpful here as well.
In a nutshell I was seeing about 15-20X speedups in my consumers when using my cython implementations.
Actually this one as well would benefit #279