Upload junit reports codecov #13778
Open
Upload junit reports codecov #13778
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Nov 8, 2025
Member
webknjaz
left a comment
webknjaz
left a comment
There was a problem hiding this comment.
It's a great start! I normally avoid adding --junitxml= (even if the path value is empty) to normal/local invocations. Instead, I like adding the entire CLI flag in the CI definition: https://github.com/cherrypy/cheroot/blob/06a6d67e549ccaefe332cd0539c21e1483031071/.github/workflows/ci-cd.yml#L786.
I've made suggestions below. Let's see if that works..
As for the change note, sometimes it's a good idea to use the contrib type for such changes.
| CI | ||
| JUNIT_XML_PATH | ||
| setenv = | ||
| _PYTEST_TOX_DEFAULT_POSARGS={env:_PYTEST_TOX_POSARGS_DOCTESTING:} {env:_PYTEST_TOX_POSARGS_LSOF:} {env:_PYTEST_TOX_POSARGS_XDIST:} {env:_PYTEST_FILES:} |
Member
There was a problem hiding this comment.
I recommend integrating it here instead
Suggested change
| _PYTEST_TOX_DEFAULT_POSARGS={env:_PYTEST_TOX_POSARGS_DOCTESTING:} {env:_PYTEST_TOX_POSARGS_LSOF:} {env:_PYTEST_TOX_POSARGS_XDIST:} {env:_PYTEST_FILES:} | |
| _PYTEST_TOX_DEFAULT_POSARGS={env:_PYTEST_TOX_POSARGS_DOCTESTING:} {env:_PYTEST_TOX_POSARGS_JUNIT:} {env:_PYTEST_TOX_POSARGS_LSOF:} {env:_PYTEST_TOX_POSARGS_XDIST:} {env:_PYTEST_FILES:} |
| if: "! matrix.use_coverage" | ||
| shell: bash | ||
| env: | ||
| JUNIT_XML_PATH: junit-${{ matrix.name }}.xml |
Member
There was a problem hiding this comment.
Suggested change
| JUNIT_XML_PATH: junit-${{ matrix.name }}.xml | |
| _PYTEST_TOX_POSARGS_JUNIT: --junitxml=junit-${{ matrix.name }}.xml |
| if: "matrix.use_coverage" | ||
| shell: bash | ||
| env: | ||
| JUNIT_XML_PATH: junit-${{ matrix.name }}.xml |
Member
There was a problem hiding this comment.
Suggested change
| JUNIT_XML_PATH: junit-${{ matrix.name }}.xml | |
| _PYTEST_TOX_POSARGS_JUNIT: --junitxml=junit-${{ matrix.name }}.xml |
Comment on lines
+45
to
+46
| {env:_PYTEST_TOX_COVERAGE_RUN:} pytest {posargs:{env:_PYTEST_TOX_DEFAULT_POSARGS:}} --junitxml={env:JUNIT_XML_PATH} | ||
| doctesting: {env:_PYTEST_TOX_COVERAGE_RUN:} pytest --doctest-modules --pyargs _pytest --junitxml={env:JUNIT_XML_PATH} |
Member
There was a problem hiding this comment.
Suggested change
| {env:_PYTEST_TOX_COVERAGE_RUN:} pytest {posargs:{env:_PYTEST_TOX_DEFAULT_POSARGS:}} --junitxml={env:JUNIT_XML_PATH} | |
| doctesting: {env:_PYTEST_TOX_COVERAGE_RUN:} pytest --doctest-modules --pyargs _pytest --junitxml={env:JUNIT_XML_PATH} | |
| {env:_PYTEST_TOX_COVERAGE_RUN:} pytest {posargs:{env:_PYTEST_TOX_DEFAULT_POSARGS:}} | |
| doctesting: {env:_PYTEST_TOX_COVERAGE_RUN:} pytest --doctest-modules {env:_PYTEST_TOX_POSARGS_JUNIT:} --pyargs _pytest |
| TERM | ||
| SETUPTOOLS_SCM_PRETEND_VERSION_FOR_PYTEST | ||
| CI | ||
| JUNIT_XML_PATH |
Member
There was a problem hiding this comment.
Suggested change
| JUNIT_XML_PATH |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR automates uploading JUnit reports to codecov in the test pipeline. An example pipeline run with the changes can be found here (https://github.com/aleguy02/fork-pytest/actions/runs/18184970357). An example of what the codecov UI looks like with these changes can be found here (https://app.codecov.io/gh/aleguy02/fork-pytest/tests).
Closes #12689
Checklist
Additional Notes
I didn't create a changelog since the documented behavior of pytest was not modified.