Force generation to use strategy defined within the factories meta #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Default in case non-set is CREATE_STRATEGY. So this conforms to the absolute hardcoded default from before.
Exelscior
force-pushed
the
topic/strategy-from-factory
branch
from
0fbad15 to
f0fadcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In regards to @witold-gren 's comment in #56 :
I agree with this statement, and see no real reason for hard-coding the build strategy when we're supposed to have a default build strategy defined within the class itself.
I made this fix for my own personnel use, and thought sharing would be of interest, as it's really small and doesn't impact my projects in any way as long as I'm aware of my build strategies used (which if I specify anything other than
CREATE_STRATEGY, it's usually for good reason).This change is