Parameter: define create as a classmethod #3403
Merged
+5
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use class method to self define itself allowing the subclassing of Parameter object and creation of the subclass
My issue was that I had to reimplement getitem to override the default behaviour before calling super:
something like
but because Parameter are instanciated with the create method hardcoding the use of Parameter, it won't use the modified class. The current solution is to reimplement also the create method. The use of the classmethod decorator in this PR allow to not make this reimplementation