Disallow transferring projects to inactive Company Organizations (#18320)

Author: ewdurbin

tests/unit/manage/test_forms.py

@@ -13,6 +13,7 @@
 from warehouse.manage import forms
 
 from ...common.constants import REMOTE_ADDR
+from ...common.db.organizations import OrganizationFactory
 from ...common.db.packaging import ProjectFactory
 
 
@@ -1008,25 +1009,30 @@ def test_validate(
 
 
 class TestTransferOrganizationProjectForm:
-    @pytest.mark.parametrize(
-        ("organization", "organization_choices", "errors"),
-        [
-            ("", [], {"organization": ["Select organization"]}),
-            ("", ["organization"], {"organization": ["Select organization"]}),
-            ("organization", ["organization"], {}),
-        ],
-    )
-    def test_validate(
-        self, pyramid_request, organization, organization_choices, errors
-    ):
-        pyramid_request.POST = MultiDict({"organization": organization})
+    def test_validate(self, pyramid_request):
+        organization = OrganizationFactory()
+        pyramid_request.POST = MultiDict({"organization": organization.id})
 
         form = forms.TransferOrganizationProjectForm(
-            pyramid_request.POST, organization_choices=organization_choices
+            pyramid_request.POST, organization_choices=[organization]
         )
 
-        assert not form.validate() if errors else form.validate(), str(form.errors)
-        assert form.errors == errors
+        assert form.validate()
+
+    def test_rejects_inactive_company(self, pyramid_request):
+        organization = OrganizationFactory(orgtype="Company")
+        pyramid_request.POST = MultiDict({"organization": organization.id})
+
+        form = forms.TransferOrganizationProjectForm(
+            pyramid_request.POST, organization_choices=[organization]
+        )
+
+        assert not form.validate()
+        assert form.errors == {
+            "organization": [
+                "Cannot transfer to Company Organization with inactive billing"
+            ]
+        }
 
 
 class TestCreateOrganizationRoleForm:

tests/unit/manage/test_views.py

@@ -2667,7 +2667,7 @@ def test_manage_project_settings_in_organization_managed(self, monkeypatch):
             "add_alternate_repository_form_class": form,
         }
         assert view.transfer_organization_project_form_class.calls == [
-            pretend.call(organization_choices={"owned-org"})
+            pretend.call(organization_choices={organization_owned})
         ]
 
     def test_manage_project_settings_in_organization_owned(self, monkeypatch):
@@ -2699,7 +2699,7 @@ def test_manage_project_settings_in_organization_owned(self, monkeypatch):
             "add_alternate_repository_form_class": form,
         }
         assert view.transfer_organization_project_form_class.calls == [
-            pretend.call(organization_choices={"managed-org"})
+            pretend.call(organization_choices={organization_managed})
         ]
 
     def test_add_alternate_repository(self, monkeypatch, db_request):
@@ -3278,7 +3278,7 @@ def test_transfer_organization_project_no_current_organization(
 
         db_request.POST = MultiDict(
             {
-                "organization": organization.normalized_name,
+                "organization": str(organization.id),
                 "confirm_transfer_organization_project_name": project.name,
             }
         )
@@ -3372,7 +3372,7 @@ def test_transfer_organization_project_no_individual_owner(
 
         db_request.POST = MultiDict(
             {
-                "organization": organization.normalized_name,
+                "organization": str(organization.id),
                 "confirm_transfer_organization_project_name": project.name,
             }
         )
@@ -3483,7 +3483,7 @@ def test_transfer_organization_project_from_organization_managed(
 
         db_request.POST = MultiDict(
             {
-                "organization": organization.normalized_name,
+                "organization": str(organization.id),
                 "confirm_transfer_organization_project_name": project.name,
             }
         )
@@ -3547,7 +3547,9 @@ def test_transfer_organization_project_from_organization_managed(
             pretend.call("manage.project.settings", project_name="foo")
         ]
         assert transfer_organization_project_form_class.calls == [
-            pretend.call(db_request.POST, organization_choices={"bar-owned", "baz"})
+            pretend.call(
+                db_request.POST, organization_choices={organization, organization_owned}
+            )
         ]
         assert isinstance(result, HTTPSeeOther)
         assert result.headers["Location"] == "/the-redirect"
@@ -3581,7 +3583,7 @@ def test_transfer_organization_project_from_organization_owned(
 
         db_request.POST = MultiDict(
             {
-                "organization": organization.normalized_name,
+                "organization": str(organization.id),
                 "confirm_transfer_organization_project_name": project.name,
             }
         )
@@ -3645,7 +3647,10 @@ def test_transfer_organization_project_from_organization_owned(
             pretend.call("manage.project.settings", project_name="foo")
         ]
         assert transfer_organization_project_form_class.calls == [
-            pretend.call(db_request.POST, organization_choices={"bar-managed", "baz"})
+            pretend.call(
+                db_request.POST,
+                organization_choices={organization_managed, organization},
+            )
         ]
         assert isinstance(result, HTTPSeeOther)
         assert result.headers["Location"] == "/the-redirect"