fix delete call to opensearch py client (#18321)

Author: ewdurbin

tests/unit/search/test_tasks.py

@@ -390,7 +390,9 @@ def project_docs(db):
                 index="warehouse-cbcbcbcbcb",
             )
         ]
-        assert es_client.indices.delete.calls == [pretend.call("warehouse-aaaaaaaaaa")]
+        assert es_client.indices.delete.calls == [
+            pretend.call(index="warehouse-aaaaaaaaaa")
+        ]
         assert es_client.indices.aliases == {"warehouse": ["warehouse-cbcbcbcbcb"]}
         assert es_client.indices.put_settings.calls == [
             pretend.call(

warehouse/search/tasks.py

@@ -196,7 +196,8 @@ def reindex(self, request):
                     actions.append({"remove": {"index": name, "alias": index_base}})
                 actions.append({"add": {"index": new_index_name, "alias": index_base}})
                 client.indices.update_aliases(body={"actions": actions})
-                client.indices.delete(",".join(to_delete))
+                for index_to_delete in to_delete:
+                    client.indices.delete(index=index_to_delete)
             else:
                 client.indices.put_alias(name=index_base, index=new_index_name)
     except redis.exceptions.LockError as exc: