-
Notifications
You must be signed in to change notification settings - Fork 325
fix(utils.py): specify utf-8 encoding when reading file #1268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
harumaki4649
wants to merge
29
commits into
pypa:main
Choose a base branch
from
harumaki4649:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+142
−5
Open
Changes from 4 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
6bb87ef
Update utils.py
harumaki4649 375173e
Update utils.py
harumaki4649 d453ba6
Add UTF-8 encoding to config file opening
harumaki4649 2fa12c5
Merge branch 'main' into main
harumaki4649 517dd30
utils.py を更新
harumaki4649 38a81a6
utils.py を更新
harumaki4649 a176289
Refactor config file parsing with helper functions
harumaki4649 a17d766
Simplify config file parsing error handling
harumaki4649 a064c86
tests: add UTF-8 fallback tests for parsing config
harumaki4649 421f3c5
Merge pull request #1 from harumaki4649/tests/add-utf8-fallback-test
harumaki4649 86b67f9
Fix assertion for configuration log message
harumaki4649 916e1c8
Refactor caplog setup in config parsing tests
harumaki4649 15aa23b
Merge branch 'pypa:main' into main
harumaki4649 1807ea5
Apply suggestion from @sigmavirus24
harumaki4649 92dcbad
Update twine/utils.py
harumaki4649 2aec62b
Update test_parse_config_encoding.py
harumaki4649 fb2003f
Merge branch 'pypa:main' into main
harumaki4649 0e30d28
Apply suggestion from @Copilot
harumaki4649 887d5cf
Apply suggestion from @Copilot
harumaki4649 de444cf
Apply suggestion from @Copilot
harumaki4649 8ba4716
Apply suggestion from @Copilot
harumaki4649 c45c3f3
Apply suggestion from @Copilot
harumaki4649 c7a44d5
Apply suggestion from @Copilot
harumaki4649 ae97e15
Apply suggestion from @Copilot
harumaki4649 b7516e0
Update twine/utils.py
harumaki4649 fe62b65
Apply suggestion from @sigmavirus24
harumaki4649 ef01422
Enhance UTF-8 fallback tests in config parsing
harumaki4649 d7cd544
Force UTF-8 encoding in config parsing tests
harumaki4649 7d9bc82
Apply suggestion from @Copilot
harumaki4649 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.