-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix links to spec schemas #1910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hugovk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
webknjaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Looks like we need another ignore for |
|
#1912 removes the Vagrant link that is causing CI problems. |
|
@ncoghlan that |
ebd5c9c to
7f2c139
Compare
|
|
|
For example, the link to https://packaging.python.org/en/latest/specifications/schemas/build-details-v1.0.schema.json in https://python-packaging-user-guide--1910.org.readthedocs.build/en/1910/specifications/build-details/v1.0/#build-details-v1-0 fails to resolve . That's going to be a recurring bootstrapping problem: if the schema metadata links to their own canonical location from the Can we instruct the link checker to resolve absolute |
Head branch was pushed to by a user without write access
7f2c139 to
bcde827
Compare
bcde827 to
3669181
Compare
FFY00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edgarrmondragon thanks for fixing this!
It isn't possible natively, but can be done via a Sphinx plugin. I'll merge the PR as-is, and open a new PR restoring the linkcheck functionality using a plugin. |
|
Opened #1950 |
See #1889 (comment).
The links in https://python-packaging-user-guide--1910.org.readthedocs.build/en/1910/specifications/schemas/ are working now :)
📚 Documentation preview 📚: https://python-packaging-user-guide--1910.org.readthedocs.build/en/1910/