Skip to content

Fix get method in models.py to not throw an exception when returning an empty item. #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix get method in models.py to not throw an exception when returning an empty item. #1289

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd69b3a
Fix get method in models.py to not throw an exception when returning …
domderen Sep 16, 2025
7544280
fix: shortening the check in get method, and adding unit tests for ne…
domderen Sep 16, 2025
5a25159
Updating tests
domderen Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pynamodb/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,9 +549,8 @@ def get(
attributes_to_get=attributes_to_get,
)
if data:
item_data = data.get(ITEM)
if item_data:
return cls.from_raw_data(item_data)
if ITEM in data:
Copy link
Contributor

@ikonst ikonst Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably if data and ITEM in data:

return cls.from_raw_data(data.get(ITEM))
raise cls.DoesNotExist()

@classmethod
Expand Down