Refactor rect properties #3492
Refactor rect properties #3492
Conversation
zoldalma999
left a comment
zoldalma999
left a comment
There was a problem hiding this comment.
There's a conflict now, because relcenter was added. Also added a nitpicky comment/question.
| RECT_ATTRIBUTE(topright, | ||
| TupleFromTwoPrimitives(self->r.x + self->r.w, self->r.y), | ||
| PrimitiveType val1; | ||
| PrimitiveType val2, twoPrimitivesFromObj(value, &val1, &val2), | ||
| self->r.x = val1 - self->r.w; | ||
| self->r.y = val2;) |
There was a problem hiding this comment.
Not sure how much the formatter allows it, but it was not clear to me that val1 and val2 are in the same argument, or what each argument does. Maybe adding comments might help?
|
Making functions inside macros is definitely tempting, especially for repetition like this. However it does make it harder to jump around the code with editor tools and sometimes to read at all. (Although rect is already pretty bad in this regard). So my idea here would be to leave the function definitions hardcoded, but use macros to take over repetitive parts / the whole of the bodies of the functions. Anyways marking as draft pending merge conflict resolution. |
3 participants
A lot of code used for different rect attributes is repeated. So this PR moves it to macro, and for each attribute only defines unique parts