-
Notifications
You must be signed in to change notification settings - Fork 313
Fraction serialization in Python mode #1854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CloseChoice
wants to merge
14
commits into
pydantic:main
Choose a base branch
from
CloseChoice:add-fraction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b46fd16
WIP: add fraction
CloseChoice 99460bf
WIP: add fraction decimal
CloseChoice 2fce2cc
WIP: try to fix linting
CloseChoice 2028880
WIP: fix linting errors and added test_fraction.py
CloseChoice ff4df27
fix linting errors
CloseChoice 5f66a65
remove test_fraction_decimal.py
CloseChoice 2c710aa
hand zero division error through
CloseChoice e8f1385
remove unnecessary code parts
CloseChoice 5ef6e2b
Update src/input/input_python.rs
CloseChoice ea51142
update fraction, add fraction validator tests and adjust to pass the …
CloseChoice 0eceff0
Merge branch 'add-fraction' of github.com:CloseChoice/pydantic-core i…
CloseChoice 556009d
remove debug statement from decimal
CloseChoice fb5cecb
adjustments based on PR comments
CloseChoice 4d38167
update things
CloseChoice File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -228,22 +228,18 @@ pub fn decimal_as_int<'py>( | |||
| Ok(EitherInt::Py(numerator)) | ||||
| } | ||||
|
|
||||
| pub fn fraction_as_int<'py>(input: &Bound<'py, PyAny>) -> ValResult<EitherInt<'py>> { | ||||
| #[cfg(Py_3_12)] | ||||
| let is_integer = input.call_method0("is_integer")?.extract::<bool>()?; | ||||
| #[cfg(not(Py_3_12))] | ||||
| let is_integer = input.getattr("denominator")?.extract::<i64>().map_or(false, |d| d == 1); | ||||
|
|
||||
| if is_integer { | ||||
| #[cfg(Py_3_11)] | ||||
| let as_int = input.call_method0("__int__"); | ||||
| #[cfg(not(Py_3_11))] | ||||
| let as_int = input.call_method0("__trunc__"); | ||||
| match as_int { | ||||
| Ok(i) => Ok(EitherInt::Py(i.as_any().to_owned())), | ||||
| Err(_) => Err(ValError::new(ErrorTypeDefaults::IntType, input)), | ||||
| } | ||||
| } else { | ||||
| Err(ValError::new(ErrorTypeDefaults::IntFromFloat, input)) | ||||
| pub fn fraction_as_int<'py>( | ||||
| input: &(impl Input<'py> + ?Sized), | ||||
| fraction: &Bound<'py, PyAny>, | ||||
| ) -> ValResult<EitherInt<'py>> { | ||||
| let py = fraction.py(); | ||||
|
|
||||
| // as_integer_ratio was added in Python 3.8, so this should be fine | ||||
|
||||
| // as_integer_ratio was added in Python 3.8, so this should be fine |
I don't think it's necessary to mention addition of such methods, as we don't support 3.8 anyway.
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think some decimal -> fraction replacement needed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, too much copy + paste ;)