Add ModelRequestParameters and ModelSettings to the ModelRequest #3405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwildehahn
force-pushed
the
mh/tool-introspection
branch
2 times, most recently
from
dea4c44 to
acced35
Compare
mwildehahn
commented
Nov 13, 2025
| if TYPE_CHECKING: | ||
| from .models.instrumented import InstrumentationSettings | ||
|
|
||
| ModelRequestParametersField = ModelRequestParameters | None |
Contributor
Author
There was a problem hiding this comment.
Even though we don't serialize these, if we don't do this the TypeAdapter will try to inspect all the fields leading to issues with some httpx types included in the models.
mwildehahn
force-pushed
the
mh/tool-introspection
branch
from
28e3d44 to
618e9a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to inspect the resolved tools / settings that were sent with the request. We don't serialize these in the ModelRequest for now since it would bloat existing serialization unnecessarily.