Check if header starts with paig on both headers #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmojaki
reviewed
Nov 13, 2025
| const apiKeyCacheKey = (key: string, kvVersion: string) => `apiKeyAuth:${kvVersion}:${key}` | ||
| const projectStateCacheKey = (project: number, kvVersion: string) => `projectState:${kvVersion}:${project}` | ||
|
|
||
| const startsWithPaig = (headerValue: string | null): headerValue is 'Bearer paig' | 'paig' => |
There was a problem hiding this comment.
surely headerValue is 'Bearer paig' | 'paig' is wrong, that would mean it's literally one of those exact values?
| const projectStateCacheKey = (project: number, kvVersion: string) => `projectState:${kvVersion}:${project}` | ||
|
|
||
| const startsWithPaig = (headerValue: string | null): headerValue is 'Bearer paig' | 'paig' => | ||
| headerValue?.startsWith('Bearer paig') || headerValue?.startsWith('paig') || false |
There was a problem hiding this comment.
Suggested change
| headerValue?.startsWith('Bearer paig') || headerValue?.startsWith('paig') || false | |
| headerValue?.toLowerCase().startsWith('bearer paig_') || headerValue?.startsWith('paig_') || false |
| } else if (!startsWithPaig(authorization) && startsWithPaig(xApiKey)) { | ||
| authHeader = xApiKey | ||
| } else { | ||
| throw new ResponseError(401, 'Unauthorized - Both Authorization and X-API-Key headers are present, use only one') |
There was a problem hiding this comment.
only worth complaining if they have different values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pydantic.slack.com/archives/C098Z504EHG/p1762245628699139