Move to opentelemetry 0.31.
#117
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cetra3
reviewed
Dec 1, 2025
| tracing = "0.1" | ||
| tracing-subscriber = { version = "0.3", features = ["env-filter"] } | ||
| tracing-opentelemetry = "0.31" | ||
| tracing-opentelemetry = { git = "https://github.com/marc-pydantic/tracing-opentelemetry", branch = "marc/opentelemetry-0.31" } |
Contributor
There was a problem hiding this comment.
Would it be easier if you move this in as a module to this crate?
Contributor
|
This may not work with the greater ecosystem as well, which sucks. There are some other crates we are using that depend on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(currently opening this to get a CI run)
The underlying
opentelemetryshould at some point migrate from0.30to0.31, if only to because some transitive dependencies have moved on, e.g.prost.The
tracing-opentelemetrycrate had some unforced changes going from0.30to0.31(opentelemetryversion, NOTtracing-opentelemetry, which confusingly is a one minor version ahead).This branch is using a fork of
tracing-opentelemetrythat has manually seen itsopentelemetryupdated.