Skip to content

Add client hello callback related functions #13634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+39 −0
Open

Add client hello callback related functions #13634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/_cffi_src/openssl/ssl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
static const long Cryptography_HAS_SRTP;
static const long Cryptography_HAS_DTLS_GET_DATA_MTU;
static const long Cryptography_HAS_SSL_GET0_GROUP_NAME;
static const long Cryptography_HAS_CLIENT_HELLO_CB;

static const long SSL_FILETYPE_PEM;
static const long SSL_FILETYPE_ASN1;
Expand Down Expand Up @@ -391,6 +392,18 @@
int DTLSv1_listen(SSL *, BIO_ADDR *);
size_t DTLS_get_data_mtu(SSL *);

/* Client hello callback support */
void SSL_CTX_set_client_hello_cb(
SSL_CTX *,
int (*)(SSL *, int *, void *),
void *);
int SSL_client_hello_get1_extensions_present(
SSL *, int **,
size_t *);
int SSL_client_hello_get0_ext(
SSL *, unsigned int,
const unsigned char **,
size_t *);

/* Custom extensions. */
typedef int (*custom_ext_add_cb)(SSL *, unsigned int,
Expand Down Expand Up @@ -685,4 +698,21 @@
static const long Cryptography_HAS_SSL_GET0_GROUP_NAME = 0;
const char *(*SSL_get0_group_name)(SSL *) = NULL;
#endif

#if CRYPTOGRAPHY_IS_LIBRESSL || CRYPTOGRAPHY_IS_BORINGSSL
static const long Cryptography_HAS_CLIENT_HELLO_CB = 0;
void (*SSL_CTX_set_client_hello_cb)(
SSL_CTX *,
int (*)(SSL *, int *, void *),
void *) = NULL;
int (*SSL_client_hello_get1_extensions_present)(
SSL *, int **,
size_t *) = NULL;
int (*SSL_client_hello_get0_ext)(
SSL *s, unsigned int,
const unsigned char **,
size_t *) = NULL;
#else
static const long Cryptography_HAS_CLIENT_HELLO_CB = 1;
#endif
"""
9 changes: 9 additions & 0 deletions src/cryptography/hazmat/bindings/openssl/_conditional.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,14 @@ def cryptography_has_ssl_get0_group_name() -> list[str]:
return ["SSL_get0_group_name"]


def cryptography_has_client_hello_cb() -> list[str]:
return [
"SSL_CTX_set_client_hello_cb",
"SSL_client_hello_get1_extensions_present",
"SSL_client_hello_get0_ext",
]


# This is a mapping of
# {condition: function-returning-names-dependent-on-that-condition} so we can
# loop over them and delete unsupported names at runtime. It will be removed
Expand Down Expand Up @@ -204,4 +212,5 @@ def cryptography_has_ssl_get0_group_name() -> list[str]:
"Cryptography_HAS_SSL_GET0_GROUP_NAME": (
cryptography_has_ssl_get0_group_name
),
"Cryptography_HAS_CLIENT_HELLO_CB": cryptography_has_client_hello_cb,
}