Fix to work with pulp and repl-toggle.el #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pulp repl` doesn't take file arguments, so it wont work with `extra-sources`
halloleo
approved these changes
Mar 4, 2022
halloleo
left a comment
halloleo
left a comment
There was a problem hiding this comment.
This change works and would be a very welcomed fix upstream.
Hi-Angel
reviewed
Jun 9, 2025
| ;;;###autoload | ||
| (defun psci (project-root-folder) | ||
| (cl-defun psci (&optional (project-root-folder (psci--project-root!))) | ||
| "Run an inferior instance of \"psci\" inside Emacs, in PROJECT-ROOT-FOLDER. |
Member
There was a problem hiding this comment.
Hi, could you please elaborate a little bit more, how does this change help making repl-toggle work? More specifically, what was the problem initially, and how does this commit help with it?
I think it might be useful to write that in the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.