(PUP-11993) Style/PercentQLiterals

This commit enables the Style/PercentQLiterals cop and fixes 3
autcorrectable offenses.

Author: AriaXLi

.rubocop_todo.yml

@@ -640,14 +640,6 @@ Style/NumericPredicate:
 Style/OptionalBooleanParameter:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: lower_case_q, upper_case_q
-Style/PercentQLiterals:
-  Exclude:
-    - 'lib/puppet/provider/package/dpkg.rb'
-    - 'lib/puppet/provider/package/rpm.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 Style/PerlBackrefs:
   Enabled: false

lib/puppet/provider/package/dpkg.rb

@@ -45,8 +45,8 @@ def self.instances
 
   # Note: self:: is required here to keep these constants in the context of what will
   # eventually become this Puppet::Type::Package::ProviderDpkg class.
-  self::DPKG_QUERY_FORMAT_STRING = %Q('${Status} ${Package} ${Version}\\n')
-  self::DPKG_QUERY_PROVIDES_FORMAT_STRING = %Q('${Status} ${Package} ${Version} [${Provides}]\\n')
+  self::DPKG_QUERY_FORMAT_STRING = %q('${Status} ${Package} ${Version}\\n')
+  self::DPKG_QUERY_PROVIDES_FORMAT_STRING = %q('${Status} ${Package} ${Version} [${Provides}]\\n')
   self::FIELDS_REGEX = %r{^'?(\S+) +(\S+) +(\S+) (\S+) (\S*)$}
   self::FIELDS_REGEX_WITH_PROVIDES = %r{^'?(\S+) +(\S+) +(\S+) (\S+) (\S*) \[.*\]$}
   self::FIELDS = [:desired, :error, :status, :name, :ensure]

lib/puppet/provider/package/rpm.rb

@@ -24,7 +24,7 @@
   # Note: self:: is required here to keep these constants in the context of what will
   # eventually become this Puppet::Type::Package::ProviderRpm class.
   # The query format by which we identify installed packages
-  self::NEVRA_FORMAT = %Q(%{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH}\\n)
+  self::NEVRA_FORMAT = %q(%{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH}\\n)
   self::NEVRA_REGEX  = %r{^'?(\S+) (\S+) (\S+) (\S+) (\S+)$}
   self::NEVRA_FIELDS = [:name, :epoch, :version, :release, :arch]
   self::MULTIVERSION_SEPARATOR = "; "