(PUP-11993) Style/PercentLiteralDelimiters

This commit enables the Style/PercentLiteralDelimiters cop and fixes
121 autocorrectable offenses.

Author: AriaXLi

.rubocop_todo.yml

@@ -640,11 +640,6 @@ Style/NumericPredicate:
 Style/OptionalBooleanParameter:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: PreferredDelimiters.
-Style/PercentLiteralDelimiters:
-  Enabled: false
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: lower_case_q, upper_case_q

ext/windows/service/daemon.rb

@@ -161,7 +161,7 @@ def report_windows_event(type, id, message)
 
   def parse_runinterval(puppet_path)
     begin
-      runinterval = %x{#{puppet_path} config --section agent --log_level notice print runinterval}.to_i
+      runinterval = %x(#{puppet_path} config --section agent --log_level notice print runinterval).to_i
       if runinterval == 0
         runinterval = 1800
         log_err("Failed to determine runinterval, defaulting to #{runinterval} seconds")
@@ -176,7 +176,7 @@ def parse_runinterval(puppet_path)
 
   def parse_log_level(puppet_path, cmdline_debug)
     begin
-      loglevel = %x{#{puppet_path} config --section agent --log_level notice print log_level}.chomp
+      loglevel = %x(#{puppet_path} config --section agent --log_level notice print log_level).chomp
       unless loglevel && respond_to?("log_#{loglevel}")
         loglevel = :notice
         log_err("Failed to determine loglevel, defaulting to #{loglevel}")

lib/puppet/application/filebucket.rb

@@ -213,7 +213,7 @@ def help
   def run_command
     @args = command_line.args
     command = args.shift
-    return send(command) if %w{get backup restore diff list}.include? command
+    return send(command) if %w[get backup restore diff list].include? command
 
     help
   end

lib/puppet/face/help.rb

@@ -194,7 +194,7 @@ def all_application_summaries
   BLANK = "\n"
   def available_application_names_special_sort
     full_list = Puppet::Application.available_application_names
-    a_list = full_list & %w{apply agent config help lookup module resource}
+    a_list = full_list & %w[apply agent config help lookup module resource]
     a_list = a_list.sort
     also_ran = full_list - a_list
     also_ran = also_ran.sort
@@ -221,7 +221,7 @@ def horribly_extract_summary_from(appname)
   # private :horribly_extract_summary_from
 
   def exclude_from_docs?(appname)
-    %w{face_base indirection_base report status}.include? appname
+    %w[face_base indirection_base report status].include? appname
   end
   # This should absolutely be a private method, but for some reason it appears
   #  that you can't use the 'private' keyword inside of a Face definition.

lib/puppet/feature/base.rb

@@ -24,7 +24,7 @@
 Puppet.features.add(:ldap, :libs => ["ldap"])
 
 # We have the Rdoc::Usage library.
-Puppet.features.add(:usage, :libs => %w{rdoc/ri/ri_paths rdoc/usage})
+Puppet.features.add(:usage, :libs => %w[rdoc/ri/ri_paths rdoc/usage])
 
 # We have libshadow, useful for managing passwords.
 Puppet.features.add(:libshadow, :libs => ["shadow"])
@@ -36,7 +36,7 @@
 end
 
 # We have lcs diff
-Puppet.features.add :diff, :libs => %w{diff/lcs diff/lcs/hunk}
+Puppet.features.add :diff, :libs => %w[diff/lcs diff/lcs/hunk]
 
 # We have OpenSSL
 Puppet.features.add(:openssl, :libs => ["openssl"])

lib/puppet/feature/pe_license.rb

@@ -3,4 +3,4 @@
 require_relative '../../puppet/util/feature'
 
 # Is the pe license library installed providing the ability to read licenses.
-Puppet.features.add(:pe_license, :libs => %{pe_license})
+Puppet.features.add(:pe_license, :libs => %(pe_license))

lib/puppet/feature/ssh.rb

@@ -2,4 +2,4 @@
 
 require_relative '../../puppet/util/feature'
 
-Puppet.features.add(:ssh, :libs => %{net/ssh})
+Puppet.features.add(:ssh, :libs => %(net/ssh))

lib/puppet/feature/zlib.rb

@@ -4,4 +4,4 @@
 
 # We want this to load if possible, but it's not automatically
 # required.
-Puppet.features.add(:zlib, :libs => %{zlib})
+Puppet.features.add(:zlib, :libs => %(zlib))

lib/puppet/http/proxy.rb

@@ -56,10 +56,10 @@ def self.no_proxy?(dest)
       # If this no_proxy entry specifies a port, we want to match it against
       # the destination port.  Otherwise just match hosts.
       if port
-        no_proxy_regex  = %r(#{host}:#{port}$)
+        no_proxy_regex  = %r{#{host}:#{port}$}
         dest_string     = "#{dest.host}:#{dest.port}"
       else
-        no_proxy_regex  = %r(#{host}$)
+        no_proxy_regex  = %r{#{host}$}
         dest_string     = "#{dest.host}"
       end
 

lib/puppet/indirector/catalog/store_configs.rb

@@ -4,5 +4,5 @@
 require_relative '../../../puppet/resource/catalog'
 
 class Puppet::Resource::Catalog::StoreConfigs < Puppet::Indirector::StoreConfigs
-  desc %q{Part of the "storeconfigs" feature. Should not be directly set by end users.}
+  desc %q(Part of the "storeconfigs" feature. Should not be directly set by end users.)
 end