(PUP-11767) Fix KeywordParametersOrder violations and remove from todo list

Author: tvpartytonight

.rubocop_todo.yml

@@ -534,11 +534,6 @@ Style/InverseMethods:
     - 'lib/puppet/reference/providers.rb'
     - 'lib/puppet/type/file.rb'
 
-# This cop supports safe auto-correction (--auto-correct).
-Style/KeywordParametersOrder:
-  Exclude:
-    - 'lib/puppet/http/service/file_server.rb'
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: line_count_dependent, lambda, literal

lib/puppet/http/service/file_server.rb

@@ -100,7 +100,7 @@ def get_file_metadata(path:, environment:, links: :manage, checksum_type: Puppet
   #
   # @api public
   #
-  def get_file_metadatas(path: nil, environment:, recurse: :false, recurselimit: nil, max_files: nil, ignore: nil, links: :manage, checksum_type: Puppet[:digest_algorithm], source_permissions: :ignore) # rubocop:disable Lint/BooleanSymbol
+  def get_file_metadatas(environment:, path: nil, recurse: :false, recurselimit: nil, max_files: nil, ignore: nil, links: :manage, checksum_type: Puppet[:digest_algorithm], source_permissions: :ignore) # rubocop:disable Lint/BooleanSymbol
     validate_path(path)
 
     headers = add_puppet_headers('Accept' => get_mime_types(Puppet::FileServing::Metadata).join(', '))