(PUP-11767) Fix InfiniteLoop violations and remove from rubocop_todo

Author: tvpartytonight

.rubocop_todo.yml

@@ -518,11 +518,6 @@ Style/IfWithSemicolon:
 Style/ImplicitRuntimeError:
   Enabled: false
 
-# This cop supports unsafe auto-correction (--auto-correct-all).
-Style/InfiniteLoop:
-  Exclude:
-    - 'lib/puppet/util/posix.rb'
-
 # This cop supports unsafe auto-correction (--auto-correct-all).
 # Configuration parameters: InverseMethods, InverseBlocks.
 Style/InverseMethods:

lib/puppet/util/posix.rb

@@ -41,7 +41,7 @@ def get_groups_list(user)
       user_gid = Puppet::Etc.getpwnam(user).gid
       ngroups = Puppet::FFI::POSIX::Constants::MAXIMUM_NUMBER_OF_GROUPS
 
-      while true do
+      loop do
         FFI::MemoryPointer.new(:int) do |ngroups_ptr|
           FFI::MemoryPointer.new(:uint, ngroups) do |groups_ptr|
             old_ngroups = ngroups