(PUP-11993) Style/ParenthesesAroundCondition

This commit enables the Style/ParenthesesAroundCondition cop and
fixes 112 autocorrectable offenses.

Author: AriaXLi

.rubocop_todo.yml

@@ -640,11 +640,6 @@ Style/NumericPredicate:
 Style/OptionalBooleanParameter:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: AllowSafeAssignment, AllowInMultilineConditions.
-Style/ParenthesesAroundCondition:
-  Enabled: false
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:

ext/windows/service/daemon.rb

@@ -36,7 +36,7 @@ def service_main(*argsv)
 
     @LOG_TO_FILE = (argsv.index('--logtofile') ? true : false)
 
-    if (@LOG_TO_FILE)
+    if @LOG_TO_FILE
       FileUtils.mkdir_p(File.dirname(LOG_FILE))
       args = args.gsub("--logtofile", "")
     end
@@ -131,7 +131,7 @@ def log_exception(e)
 
   def log(msg, level)
     if LEVELS.index(level) >= @loglevel
-      if (@LOG_TO_FILE)
+      if @LOG_TO_FILE
         # without this change its possible that we get Encoding errors trying to write UTF-8 messages in current codepage
         File.open(LOG_FILE, 'a:UTF-8') { |f| f.puts("#{Time.now} Puppet (#{level}): #{msg}") }
       end
@@ -153,7 +153,7 @@ def report_windows_event(type, id, message)
     rescue Exception
       # Ignore all errors
     ensure
-      unless (eventlog.nil?)
+      unless eventlog.nil?
         eventlog.close
       end
     end

lib/puppet/agent/disabler.rb

@@ -26,7 +26,7 @@ def enable
   def disable(msg = nil)
     data = {}
     Puppet.notice _("Disabling Puppet.")
-    unless (msg.nil?)
+    unless msg.nil?
       data[DISABLED_MESSAGE_JSON_KEY] = msg
     end
     disable_lockfile.lock(data)

lib/puppet/application.rb

@@ -180,7 +180,7 @@ def controlled_run(&block)
     def option(*options, &block)
       long = options.find { |opt| opt =~ /^--/ }.gsub(/^--(?:\[no-\])?([^ =]+).*$/, '\1').tr('-', '_')
       fname = "handle_#{long}".intern
-      if (block_given?)
+      if block_given?
         define_method(fname, &block)
       else
         define_method(fname) do |value|
@@ -242,7 +242,7 @@ def find(application_name)
       ####  eventually we need to issue a deprecation warning here,
       ####  and then get rid of this stanza in a subsequent release.
       ################################################################
-      if (clazz.nil?)
+      if clazz.nil?
         class_name = application_name.capitalize
         clazz = try_load_class(class_name)
       end

lib/puppet/application/face_base.rb

@@ -88,7 +88,7 @@ def parse_options
           # when we get there. --daniel 2011-04-04
           if option.takes_argument? and !item.index('=')
             index += 1 unless
-              (option.optional_argument? and command_line.args[index + 1] =~ /^-/)
+              option.optional_argument? and command_line.args[index + 1] =~ /^-/
           end
         else
           option = find_global_settings_argument(item)
@@ -103,7 +103,7 @@ def parse_options
           else
             option = find_application_argument(item)
             if option
-              index += 1 if (option[:argument] and !(option[:optional]))
+              index += 1 if option[:argument] and !(option[:optional])
             else
               raise OptionParser::InvalidOption.new(item.sub(/=.*$/, ''))
             end

lib/puppet/configurer.rb

@@ -390,7 +390,7 @@ def run_internal(options)
       configured_environment = Puppet[:environment] if Puppet.settings.set_by_config?(:environment)
 
       # We only need to find out the environment to run in if we don't already have a catalog
-      unless (cached_catalog || options[:catalog] || Puppet.settings.set_by_cli?(:environment) || Puppet[:strict_environment_mode])
+      unless cached_catalog || options[:catalog] || Puppet.settings.set_by_cli?(:environment) || Puppet[:strict_environment_mode]
         Puppet.debug(_("Environment not passed via CLI and no catalog was given, attempting to find out the last server-specified environment"))
         initial_environment, loaded_last_environment = last_server_specified_environment
 

lib/puppet/error.rb

@@ -28,7 +28,7 @@ def initialize(message, file = nil, line = nil, pos = nil, original = nil)
 
       super(message, original)
 
-      @file = file unless (file.is_a?(String) && file.empty?)
+      @file = file unless file.is_a?(String) && file.empty?
       @line = line
       @pos = pos
 
@@ -41,7 +41,7 @@ def initialize(message, file = nil, line = nil, pos = nil, original = nil)
 
     def to_s
       msg = super
-      @file = nil if (@file.is_a?(String) && @file.empty?)
+      @file = nil if @file.is_a?(String) && @file.empty?
       msg += Puppet::Util::Errors.error_location_with_space(@file, @line, @pos)
       msg
     end

lib/puppet/face/epp.rb

@@ -417,7 +417,7 @@ def get_values(compiler, options)
       rescue => e
         Puppet.err(_("Could not load --values_file %{error}") % { error: e.message })
       end
-      unless (template_values.nil? || template_values.is_a?(Hash))
+      unless template_values.nil? || template_values.is_a?(Hash)
         Puppet.err(_("--values_file option must evaluate to a Hash or undef/nil, got: '%{template_class}'") % { template_class: template_values.class })
       end
     end

lib/puppet/face/help.rb

@@ -160,9 +160,9 @@ def all_application_summaries
     available_application_names_special_sort().inject([]) do |result, appname|
       next result if exclude_from_docs?(appname)
 
-      if (appname == COMMON || appname == SPECIALIZED || appname == BLANK)
+      if appname == COMMON || appname == SPECIALIZED || appname == BLANK
         result << appname
-      elsif (is_face_app?(appname))
+      elsif is_face_app?(appname)
         begin
           face = Puppet::Face[appname, :current]
           # Add deprecation message to summary if the face is deprecated

lib/puppet/face/module/list.rb

@@ -259,8 +259,8 @@ def list_build_node(mod, parent, params)
         str << '  ' + colorize(:red, _('invalid'))
       elsif parent.respond_to?(:forge_name)
         unmet_parent = @unmet_deps[:version_mismatch][mod.forge_name][:parent]
-        if (unmet_parent[:name] == parent.forge_name &&
-            unmet_parent[:version] == "v#{parent.version}")
+        if unmet_parent[:name] == parent.forge_name &&
+           unmet_parent[:version] == "v#{parent.version}"
           str << '  ' + colorize(:red, _('invalid'))
         end
       end