Skip to content

Conversation

@SagePtr
Copy link
Contributor

@SagePtr SagePtr commented Nov 24, 2025

Fix deprecation warnings in PHP 8.4 and PHP 8.5:

PHP Deprecated:  JsPhpize\Nodes\Dyiade::__construct(): Implicitly marking parameter $before as nullable is deprecated, the explicit nullable type must be used instead in vendor/js-phpize/js-phpize/src/JsPhpize/Nodes/Dyiade.php on line 29
PHP Deprecated:  JsPhpize\Nodes\Dyiade::__construct(): Implicitly marking parameter $after as nullable is deprecated, the explicit nullable type must be used instead in vendor/js-phpize/js-phpize/src/JsPhpize/Nodes/Dyiade.php on line 29

UPD: this will break PHP 7.0 compatibility (which support ended 6 years ago)

@kylekatarnls
Copy link
Member

Hello, thanks for raising. ?array is not compatible with PHP 7.0, however I checked, and we don't need to keep them nullable. I'll switch those to pure array parameters in #42 which will be compatible with all versions from 7.0 to 8.5.

@kylekatarnls
Copy link
Member

Fixed in version 2.9.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants