Skip to content

Remove need for --begin-sql comments #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove need for --begin-sql comments #4

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8577076
remove need for wrapping --begin-sql etc comments
akdor1154 Mar 13, 2021
0481c51
make pattern case insensitive
akdor1154 Mar 13, 2021
e26760e
update docs and demo
akdor1154 Mar 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions syntaxes/highlight-sql-string.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,17 @@
"injectionSelector": "L:string.quoted.multi.python, L:meta.fstring.python - (comment.line.number-sign.python, punctuation.definition.comment.python)",
"patterns": [
{
"begin": "( *--sql| *--beginsql| *--begin-sql)",
Copy link

@cikay cikay Nov 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not recommend to remove the current identifiers. It would break all implementation. Add new ones but do not remove the current ones.

Copy link
Author

@akdor1154 akdor1154 Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks for getting to this :)

Copy link
Author

@akdor1154 akdor1154 Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you are not maintainer haha. You're probably right but ill wait to hear from repo owner/member if they are still alive...

"end": "( *;| *--endsql| *--end-sql)",
"captures": {
"1": {
"name": "variable.parameter"
}
"name": "meta.embedded.sql",
"begin": "\\s*((select|with)|(--.*))",
"end": "(?=\"\"\")",
"beginCaptures": {
"2": { "name": "keyword.other.DML.sql" },
"3": { "name": "comment.line.double-dash.sql" }
},
"patterns": [
{
"include": "source.sql"
}
{ "include": "source.sql" }
]
}
],
"scopeName": "python-sql.injection"
}
}