Fixes from 4.1.6 release cherry-picked/adapted for master #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kblaschke
force-pushed
the
small-fixes
branch
from
8aaaf62 to
49c0df5
Compare
Open
2 tasks
…hader Only custom waves set the point size to 2, default waveforms still render the 2x2 pattern when using dots. Other draw calls aren't affected as they only draw lines/triangles, but it's good practice to not leave the uniform in an undefined state. Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
All waves were rendered upside-down, breaking presets requiring the wave to be at the top or bottom due to warp movement. Using the flipped transformation matrix for drawing will take care of this globally. Also fixed two small mistakes regarding operators. Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
Since this might be vendor-specific behavior, a new API function to configure the X/Y texel offsets has been added. Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
Fixes "martin - mayday (shifters escape retouched).milk" and probably some others. Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
…eadability. Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
…eral 1 as exponent Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
Previously, if the TextureManager was recreated, e.g. when changing the texture paths, all loaded textures were deleted, even if currently in use by a preset. Storing textures and samplers as shared pointers instead of weak pointers will make sure the objects are kept alive until the preset is unloaded. Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
Signed-off-by: Kai Blaschke <kai.blaschke@kb-dev.net>
kblaschke
force-pushed
the
small-fixes
branch
from
49c0df5 to
6515340
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes just released in v4.1.6 cherry-picked for master and, where applicable, changed to fit the renderer refactoring where necessary.