Fixing #46 by adding an optional argument to disable riase_for_status #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riase_for_status
Author
|
@DaleSeo can I get one of the repo maintainers to review |
xkludge
requested changes
May 8, 2023
Contributor
xkludge
left a comment
xkludge
left a comment
There was a problem hiding this comment.
Thanks for the contribution, could you by chance add a unit test that will cover the two scenarios of toggling this flag?
| variables: dict = None, | ||
| operation_name: str = None, | ||
| headers: dict = {}, | ||
| riase_for_status: bool = True, |
Contributor
There was a problem hiding this comment.
By chance did you mean?
Suggested change
| riase_for_status: bool = True, | |
| raise_for_status: bool = True, |
| **{**self.options, **kwargs}, | ||
| ) | ||
|
|
||
| if riase_for_status: |
Contributor
There was a problem hiding this comment.
Suggested change
| if riase_for_status: | |
| if raise_for_status: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #46
What is the current behavior?
Currently riase_for_status will mask/eat errors from graphql servers that can respond explaining the error.
This allows users to disable that functionality and have the json of the response returned; which would include the error.
What is the new behavior?
Default behavior remains the same; however an optional argument is now available that lets user disable the use of riase_for_status to catch errors.
Does this PR introduce a breaking change?
No; not that I am aware of.
Other information