Skip to content

Conversation

@mmahsereci
Copy link
Contributor

@mmahsereci mmahsereci commented Nov 23, 2022

In a Nutshell

This PR adds initial designs to the quad package. Further, bayesquad and related methods now expose an options dictionary for optional parameters similar to some scipy methods. This is because the api became increasingly messy when new options are added.

Detailed Description

should be reviewed after #744 is merged.

Related Issues

Closes #...

@mmahsereci mmahsereci requested review from a team and tskarvone as code owners November 23, 2022 18:00
@mmahsereci mmahsereci marked this pull request as draft November 23, 2022 18:00
@mmahsereci mmahsereci self-assigned this Nov 23, 2022
@mmahsereci mmahsereci added the quad Issues related to quadrature label Nov 23, 2022
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #745 (42d579d) into main (8dde541) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
+ Coverage   90.54%   90.69%   +0.14%     
==========================================
  Files         202      206       +4     
  Lines        7552     7638      +86     
  Branches      974      982       +8     
==========================================
+ Hits         6838     6927      +89     
+ Misses        480      479       -1     
+ Partials      234      232       -2     
Impacted Files Coverage Δ
src/probnum/quad/_bayesquad.py 100.00% <100.00%> (ø)
src/probnum/quad/solvers/__init__.py 100.00% <100.00%> (ø)
src/probnum/quad/solvers/_bayesian_quadrature.py 100.00% <100.00%> (+3.26%) ⬆️
...c/probnum/quad/solvers/initial_designs/__init__.py 100.00% <100.00%> (ø)
...um/quad/solvers/initial_designs/_initial_design.py 100.00% <100.00%> (ø)
...bnum/quad/solvers/initial_designs/_latin_design.py 100.00% <100.00%> (ø)
...probnum/quad/solvers/initial_designs/_mc_design.py 100.00% <100.00%> (ø)
...um/quad/solvers/policies/_van_der_corput_policy.py 100.00% <100.00%> (ø)

@mmahsereci mmahsereci marked this pull request as ready for review November 25, 2022 16:46
Copy link
Contributor

@JonathanWenger JonathanWenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@mmahsereci mmahsereci merged commit 4f434ca into probabilistic-numerics:main Nov 28, 2022
@mmahsereci mmahsereci deleted the mm-quad-init-designs branch November 28, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

quad Issues related to quadrature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants