Skip to content

Feature/docker support #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Feature/docker support #87

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b56d357
docker support was added
DefeNder93 Sep 9, 2017
0b0a678
fix readme section
DefeNder93 Sep 9, 2017
cdd79f6
fix readme
DefeNder93 Sep 9, 2017
e1b042f
fix readme
DefeNder93 Sep 9, 2017
f98d44e
settings for containers was added, build was changed to production, e…
DefeNder93 Sep 11, 2017
c214f2e
revert of npm script
DefeNder93 Sep 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "A workflow for Angular made with Webpack",
"scripts": {
"build": "rimraf dist && webpack --bail --progress --profile",
"server": "webpack-dev-server --host 0.0.0.0 --port 8080 --history-api-fallback --inline --progress",
"server": "webpack-dev-server --history-api-fallback --inline --progress",
Copy link
Member

@phra phra Sep 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was the command changed?

Copy link
Author

@DefeNder93 DefeNder93 Sep 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted it by this commit. In the first place, I wanted to use webpack-dev-server and I needed to change host to 0.0.0.0 to make it work (to fix ERR_CONNECTION_REFUSED error). But then I realized that it's better to use separated web-server (in this case express) and build command because webpack-dev-server is not good for production.

"test": "karma start",
"test-watch": "karma start --auto-watch --no-single-run",
"start": "npm run server"
Expand Down