Improve Logging and Exception Handling

src/main/java/com/prashant/springbootcrud/Controller/MainController.java

@@ -4,6 +4,8 @@
 
 import javax.sound.midi.ControllerEventListener;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
@@ -24,36 +26,53 @@
 @RequestMapping("/rest")
 public class MainController {
 
+
+	public static final Logger log= LoggerFactory.getLogger("Controller logs");
+
 	@Autowired
 	EmployeeServiceInterface employeeServiceInterface;
 
 	@GetMapping("/getAllEmployee")
-	public List<Employee> getAllEmployee() {
-		System.out.println("Inside Employee Repository");
-		return employeeServiceInterface.getAllEmployee();
+	public ResponseEntity<List<Employee>> getAllEmployee() {
+		try {
+			log.info("Inside Employee Repository");
+			return employeeServiceInterface.getAllEmployee();
+		}catch (Exception e){
+			log.error(e.getMessage());
+			e.printStackTrace();
+			return ResponseEntity.badRequest().build();
+		}
 	}
 
 	@PostMapping("/create")
 	public ResponseEntity<?> createEmployee(@RequestBody Employee employee) {
 		try {
-			Employee empCreated = employeeServiceInterface.createEmployee(employee);
-			return new ResponseEntity<Employee>(empCreated, HttpStatus.CREATED);
+			return ResponseEntity.ok(employeeServiceInterface.createEmployee(employee));
 		} catch (BusinessException e) {
 			ControllerException ce = new ControllerException(e.getErrorCode(), e.getErrorMessage());
 			return new ResponseEntity<ControllerException>(ce, HttpStatus.BAD_REQUEST);
 		}
-
 	}
-
 	@PostMapping("/createMultiple")
-	public void createEmployeeList(@RequestBody List<Employee> employeeList) {
-
-		employeeServiceInterface.createEmployee(employeeList);
+	public ResponseEntity<String> createEmployeeList(@RequestBody List<Employee> employeeList) {
+		try {
+			return employeeServiceInterface.createEmployee(employeeList);
+		}catch (Exception e){
+			log.error(e.getMessage());
+			e.printStackTrace();
+			return ResponseEntity.badRequest().build();
+		}
 	}
 
 	@DeleteMapping("/deleteAll")
-	public void deleteEmployees() {
-		employeeServiceInterface.deleteEmployee();
+	public ResponseEntity<String> deleteEmployees() {
+		try {
+			return employeeServiceInterface.deleteEmployee();
+		}catch (Exception e){
+			log.error(e.getMessage());
+			e.printStackTrace();
+			return ResponseEntity.badRequest().build();
+		}
 	}
 
 }

src/main/java/com/prashant/springbootcrud/Service/EmployeeService.java

@@ -4,7 +4,10 @@
 
 import org.hibernate.Session;
 import org.hibernate.SessionFactory;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.http.ResponseEntity;
 import org.springframework.stereotype.Service;
 
 import com.prashant.springbootcrud.ExceptionHandeling.BusinessException;
@@ -14,17 +17,17 @@
 
 @Service
 public class EmployeeService implements EmployeeServiceInterface {
-
+	public static final Logger log = LoggerFactory.getLogger("Service Logs");
 	@Autowired
 	EmployeeRepository employeeRepository;
 
 	@Override
-	public Employee createEmployee(Employee employee) {
+	public ResponseEntity<Employee> createEmployee(Employee employee) {
 		if (employee.getName().isEmpty() || employee.getName().length() == 0) {
 			throw new BusinessException("600", "No name value provided for the emplyee Name!!");
 		}
 		try {
-			return employeeRepository.save(employee);
+			return ResponseEntity.ok(employeeRepository.save(employee));
 		}
 
 		catch (IllegalArgumentException e) {
@@ -34,26 +37,37 @@ public Employee createEmployee(Employee employee) {
 	}
 
 	@Override
-	public void createEmployee(List<Employee> employeeList) {
-
-		SessionFactory sessionFactory = SessionFactoryHelper.getSessionFactory();
-		Session session = sessionFactory.openSession();
-		session.beginTransaction();
-
-		session.save(employeeList);
-		session.getTransaction().commit();
-		session.close();
+	public ResponseEntity<String> createEmployee(List<Employee> employeeList) {
+		try {
+			SessionFactory sessionFactory = SessionFactoryHelper.getSessionFactory();
+			Session session = sessionFactory.openSession();
+			session.beginTransaction();
 
+			session.save(employeeList);
+			session.getTransaction().commit();
+			session.close();
+			return ResponseEntity.ok("Employee created Successfully!!!");
+		}catch (Exception e){
+			log.error(e.getMessage());
+			e.printStackTrace();
+			return ResponseEntity.badRequest().build();
+		}
 	}
 
 	@Override
-	public void deleteEmployee() {
-
-		employeeRepository.deleteAll();
+	public ResponseEntity<String> deleteEmployee() {
+		try {
+			employeeRepository.deleteAll();
+			return ResponseEntity.ok("Employee Deleted Successfully!!!");
+		}catch (Exception e){
+			log.error(e.getMessage());
+			e.printStackTrace();
+			return ResponseEntity.badRequest().build();
+		}
 	}
 
 	@Override
-	public List<Employee> getAllEmployee() {
-		return employeeRepository.findAll();
+	public ResponseEntity<List<Employee>> getAllEmployee() {
+		return ResponseEntity.ok(employeeRepository.findAll());
 	}
 }

src/main/java/com/prashant/springbootcrud/Service/EmployeeServiceInterface.java

@@ -3,15 +3,16 @@
 import java.util.List;
 
 import com.prashant.springbootcrud.Model.Employee;
+import org.springframework.http.ResponseEntity;
 
 public interface EmployeeServiceInterface {
 
-	public Employee createEmployee(Employee employee);
+	public ResponseEntity<Employee> createEmployee(Employee employee);
 
-	public void createEmployee(List<Employee> employeeList);
+	public ResponseEntity<String> createEmployee(List<Employee> employeeList);
 
-	public void deleteEmployee();
+	public ResponseEntity<String> deleteEmployee();
 
-	public List<Employee> getAllEmployee();
+	public ResponseEntity<List<Employee>> getAllEmployee();
 
 }