CI: Port ec2_compatibilitytests #665
Conversation
|
Hi @hanno-becker , sorry to bother you, |
|
@willieyz I don't recall the specifics, unfortunately, but I think it's mainly about the docker installation. Have you tried just using the same AMIs in mldsa-native? |
willieyz
force-pushed
the
ec2-compatibilitytests
branch
5 times, most recently
from
e632cc3 to
20112a6
Compare
willieyz
force-pushed
the
ec2-compatibilitytests
branch
2 times, most recently
from
c1c56a2 to
5ecc83b
Compare
I thought you can't use the same AMIs as they are bound to the mlkem-native account? Or what am I missing here? |
willieyz
force-pushed
the
ec2-compatibilitytests
branch
7 times, most recently
from
d8c75cd to
af19d17
Compare
willieyz
force-pushed
the
ec2-compatibilitytests
branch
from
af19d17 to
2b80aee
Compare
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks @willieyz - looks mostly good!
Please clean-up the commit history. This feels like one logical change.
Also please address the left-over TODO in ci_ec2_container.yml.
willieyz
force-pushed
the
ec2-compatibilitytests
branch
from
2b80aee to
3a27a00
Compare
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
One nit. Then this is good to go.
willieyz
force-pushed
the
ec2-compatibilitytests
branch
2 times, most recently
from
314a31e to
dbf8138
Compare
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
LGTM. Thanks @willieyz!
- This commit port ec2_compatibilitytests from mlkem to mldsa
- Also, due to the requement for ci_ec2_container.yml, this commit add
the ci_ec2_container.yml based on ci_ec2_reuseable.yml,
referencing from mlkem-native
- About the AMI and AWS_ROLE we use, this commit aligns the AWS_ROLE and
other parameters with those used in mlkem-native. we now use the same
AMI, AWS_ROLE, and related configuration parameters for
ec2_compatibilitytests to ensure consistency with mlkem-native.
- Skip ACVP tests on Amazon Linux 2 containers when Python on these
containers does not support hashlib sha512_224.
- when adding several containers to ec2_compatibilitytests, we found
that three Amazon Linux 2 containers could not run ACVP tests
correctly due to missing support for newer hashlib hash types:
* `amazonlinux-2-aarch:base`
* `amazonlinux-2-aarch:gcc-7x`
* `amazonlinux-2-aarch:clang-7x`
- For these containers, we set `acvptest` to false. We also added a guard
around `make quickcheck` in `ci_ec2_container.yml` and left a comment
for future refinement.
Signed-off-by: willieyz <willie.zhao@chelpis.com>
mkannwischer
force-pushed
the
ec2-compatibilitytests
branch
from
dbf8138 to
8e0b777
Compare
Resolves: CI: Port
ec2_compatibilitytests#583This PR ports the
ec2_compatibilitytestsworkflow tomldsa-native, based on the implementation in mlkem-native.Main changes:
During testing, the following Amazon Linux 2 containers failed ACVP tests due to missing
sha512_224support:(This failure is unrelated to test correctness; the issue is solely the missing hash support required for computing the verification value.)
amazonlinux-2-aarch:baseamazonlinux-2-aarch:gcc-7xamazonlinux-2-aarch:clang-7xFor these containers,
acvptestis set to false, and a guard aroundmake quickcheckhas been added with a comment for future refinement.