Skip to content

fix: large datasets on android 12 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2024
Merged

fix: large datasets on android 12 #28

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0fb8b34
fix setting temp_store to memory
Apr 24, 2024
b2f95d9
Merge branch 'main' into fix-temp-store
Apr 24, 2024
89e7399
chore: ensuring user defined flags override memory flag and removed p…
Apr 24, 2024
ffbccff
removed changeset file
Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gorgeous-chefs-do.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@journeyapps/react-native-quick-sqlite': patch
---

Fixed order of makefile flags
5 changes: 5 additions & 0 deletions .changeset/wise-stingrays-float.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@journeyapps/react-native-quick-sqlite': patch
---

Use memory temp_store
1 change: 1 addition & 0 deletions android/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ include_directories(
)

add_definitions(
-DSQLITE_TEMP_STORE=2
${SQLITE_FLAGS}
)

Expand Down
3 changes: 0 additions & 3 deletions tests/tests/sqlite/rawQueries.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,9 +566,6 @@ export function registerBaseTests() {
// Execute the read test whenever a table change ocurred
db.registerTablesChangedHook((update) => readTriggerCallbacks.forEach((cb) => cb()));

// Needed for large volumes of data on older Android devices
// https://github.com/margelo/react-native-quick-sqlite/pull/25
await db.execute('PRAGMA temp_store = memory;')
const numberOfUsers = 100_000;
await db.writeLock(async (tx) => {
await tx.execute('BEGIN');
Expand Down