Skip to content

refactor: replace deprecated ESLint CLIEngine with modern ESLint class #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

refactor: replace deprecated ESLint CLIEngine with modern ESLint class #796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions npm/test-lint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ require('shelljs/global');

var chalk = require('chalk'),
async = require('async'),
ESLintCLIEngine = require('eslint').CLIEngine,
{ ESLint } = require('eslint'),

/**
* The list of source code files / directories to be linted.
Expand All @@ -29,8 +29,14 @@ module.exports = function (exit) {
* @param {Function} next - The callback function whose invocation marks the end of the lint test run.
* @returns {*}
*/
function (next) {
next(null, (new ESLintCLIEngine()).executeOnFiles(LINT_SOURCE_DIRS));
async function (next) {
const eslint = new ESLint();
try {
const results = await eslint.lintFiles(LINT_SOURCE_DIRS);
next(null, { results });
} catch (error) {
next(error);
}
},

/**
Expand All @@ -41,14 +47,19 @@ module.exports = function (exit) {
* @param {Function} next - The callback whose invocation marks the completion of the post run tasks.
* @returns {*}
*/
function (report, next) {
var errorReport = ESLintCLIEngine.getErrorResults(report.results);
// log the result to CLI
console.info(ESLintCLIEngine.getFormatter()(report.results));
// log the success of the parser if it has no errors
(errorReport && !errorReport.length) && console.info(chalk.green('eslint ok!'));
// ensure that the exit code is non zero in case there was an error
next(Number(errorReport && errorReport.length) || 0);
async function (report, next) {
try {
var errorReport = ESLint.getErrorResults(report.results);
// log the result to CLI
const formatter = await ESLint.loadFormatter();
console.info(formatter.format(report.results));
// log the success of the parser if it has no errors
(errorReport && !errorReport.length) && console.info(chalk.green('eslint ok!'));
// ensure that the exit code is non zero in case there was an error
next(Number(errorReport && errorReport.length) || 0);
} catch (error) {
next(error);
}
}
], exit);
};
Expand Down