Fix doc deploy #144
Fix doc deploy #144
Conversation
| push: | ||
| branches: | ||
| - "master" | ||
| workflow_dispatch: |
There was a problem hiding this comment.
I'm all for adding workflow_dispatch:, but why are you removing the push: branches: - "master" lines?
There was a problem hiding this comment.
Never mind. I get it. We want the docs to only update when there's a new release. May I suggest the following instead?
on:
release:
types: [published]
workflow_dispatch:
That will trigger automatically only when a new release is published. In the context of a GitHub Actions workflow, "published" means that a release has been finalized and made visible to the public, or specifically, marked as a non-draft and non-prerelease version. This is distinct from simply saving a draft.
The docs should be deployed when a new release is publishing. There is no point to deploy the docs every time when the master branch is updated. The proposed change sets automatic doc deployment only on a new release publication or manually.
vitcpp
force-pushed
the
fix-doc-deploy
branch
from
dbf218a to
c77b3cc
Compare
|
@esabol Thank you for the idea. I've added doc deployment on release publication. |
|
Looks good, I hope this will get the GitHub Actions workflow to update the documentation on the website working again. This PR will also close issue #132. |
2 participants
No description provided.