Skip to content

Issue #139: Add PostgreSQL 18 builds to CI workflow, fix tests on PostgreSQL 18+, and eliminate compilation warnings #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2025
Merged

Issue #139: Add PostgreSQL 18 builds to CI workflow, fix tests on PostgreSQL 18+, and eliminate compilation warnings #140

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7eb49a9
Issue #139: Add PostgreSQL 18 builds to CI workflow
esabol Oct 7, 2025
ee249b7
Applied patch from @vitcpp to fix selectivity test on PostgreSQL 18
esabol Oct 8, 2025
bdbc6a3
Fix compiler warnings about missing variable declarations
esabol Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions src/sbuffer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
#define MAX_BUF_ANGLE 20

/* The type of parsed spherical object. */
unsigned char spheretype;
static unsigned char spheretype;

/* The angle buffer. */
float8 bufangle[MAX_BUF_ANGLE];
static float8 bufangle[MAX_BUF_ANGLE];

/* A simple spherical point. */
typedef struct
Expand All @@ -20,43 +20,43 @@ typedef struct
} bpoint;

/* Spherical point buffer. */
struct
static struct
{
int m; /* count of buffered points */
bpoint *p; /* pointer to array of points */
} bufpoints;

/* ID of line's length angle. */
int bufline;
static int bufline;

/*
* First element is the ID of spherical point ( center ).
* Second element is the ID of radius angle.
*/
int bufcircle[2];
static int bufcircle[2];

/* Buffer of ellipse. */
int bufellipse[5];
static int bufellipse[5];

/* Buffer of IDs of Euler transformation values. */
int bufeuler[3];
static int bufeuler[3];

/* Structure to buffer the axes of Euler transformation. */
struct
static struct
{
unsigned char phi, /* first axis */
theta, /* second axis */
psi; /* third axis */
} bufeulertype;

/* Current angle ID. */
int bufapos;
static int bufapos;

/* Current point ID. */
int bufspos;
static int bufspos;

/* Pointer to input buffer. */
char *parse_buffer;
static char *parse_buffer;


void
Expand Down
4 changes: 3 additions & 1 deletion src/sbuffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@
#define EULER_AXIS_Y 2 /* y - axis for Euler transformation */
#define EULER_AXIS_Z 3 /* z - axis for Euler transformation */

extern int sphere_yylex();
extern int sphere_yychar;
Copy link
Contributor

@vitcpp vitcpp Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about extern declaration of these variables. They are not used in the code except of sparse.c.

extern int sphere_yynerrs;
extern int sphere_yylex();
extern void sphere_yyerror(const char *str);
extern void sphere_flush_scanner_buffer(void);

Expand Down