check that table is partitioned by RANGE in create_single_range_partition()

Author: funbringer

expected/pathman_calamity.out

@@ -102,8 +102,19 @@ SELECT count(*) FROM calamity.part_test;
 
 DELETE FROM calamity.part_test;
 /* test function create_single_range_partition() */
-SELECT create_single_range_partition(NULL, NULL::INT4, NULL); /* not ok */
+SELECT create_single_range_partition(NULL, NULL::INT4, NULL);					/* not ok */
 ERROR:  'parent_relid' should not be NULL
+SELECT create_single_range_partition('pg_class', NULL::INT4, NULL);				/* not ok */
+ERROR:  table "pg_class" is not partitioned by RANGE
+SELECT add_to_pathman_config('calamity.part_test', 'val');
+ add_to_pathman_config 
+-----------------------
+ t
+(1 row)
+
+SELECT create_single_range_partition('calamity.part_test', NULL::INT4, NULL);	/* not ok */
+ERROR:  table "part_test" is not partitioned by RANGE
+DELETE FROM pathman_config WHERE partrel = 'calamity.part_test'::REGCLASS;
 /* test function create_range_partitions_internal() */
 SELECT create_range_partitions_internal(NULL, '{}'::INT[], NULL, NULL);		/* not ok */
 ERROR:  'parent_relid' should not be NULL

sql/pathman_calamity.sql

@@ -37,7 +37,13 @@ DELETE FROM calamity.part_test;
 
 
 /* test function create_single_range_partition() */
-SELECT create_single_range_partition(NULL, NULL::INT4, NULL); /* not ok */
+SELECT create_single_range_partition(NULL, NULL::INT4, NULL);					/* not ok */
+SELECT create_single_range_partition('pg_class', NULL::INT4, NULL);				/* not ok */
+
+SELECT add_to_pathman_config('calamity.part_test', 'val');
+SELECT create_single_range_partition('calamity.part_test', NULL::INT4, NULL);	/* not ok */
+DELETE FROM pathman_config WHERE partrel = 'calamity.part_test'::REGCLASS;
+
 
 /* test function create_range_partitions_internal() */
 SELECT create_range_partitions_internal(NULL, '{}'::INT[], NULL, NULL);		/* not ok */

src/pl_range_funcs.c

@@ -100,6 +100,9 @@ create_single_range_partition_pl(PG_FUNCTION_ARGS)
 	RangeVar   *partition_name_rv;
 	char	   *tablespace;
 
+	Datum		values[Natts_pathman_config];
+	bool		isnull[Natts_pathman_config];
+
 
 	/* Handle 'parent_relid' */
 	if (!PG_ARGISNULL(0))
@@ -109,6 +112,15 @@ create_single_range_partition_pl(PG_FUNCTION_ARGS)
 	else ereport(ERROR, (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
 						 errmsg("'parent_relid' should not be NULL")));
 
+	/* Check that table is partitioned by RANGE */
+	if (!pathman_config_contains_relation(parent_relid, values, isnull, NULL, NULL) ||
+		DatumGetPartType(values[Anum_pathman_config_parttype - 1]) != PT_RANGE)
+	{
+		ereport(ERROR, (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
+						 errmsg("table \"%s\" is not partitioned by RANGE",
+								get_rel_name_or_relid(parent_relid))));
+	}
+
 	bounds_type = get_fn_expr_argtype(fcinfo->flinfo, 1);
 
 	start = PG_ARGISNULL(1) ?