drop function create_partitions_from_range()

funbringer · funbringer · commit 018428265817 · 2017-06-05T19:04:25.000+03:00
diff --git a/README.md b/README.md
@@ -122,22 +122,6 @@ create_range_partitions(relation       REGCLASS,
 ```
 Performs RANGE partitioning for `relation` by partitioning key `attribute`, `start_value` argument specifies initial value, `p_interval` sets the default range for auto created partitions or partitions created with `append_range_partition()` or `prepend_range_partition()` (if `NULL` then auto partition creation feature won't work), `p_count` is the number of premade partitions (if not set then `pg_pathman` tries to determine it based on attribute values). Partition creation callback is invoked for each partition if set beforehand.
 
-```plpgsql
-create_partitions_from_range(relation       REGCLASS,
-                             attribute      TEXT,
-                             start_value    ANYELEMENT,
-                             end_value      ANYELEMENT,
-                             p_interval     ANYELEMENT,
-                             partition_data BOOLEAN DEFAULT TRUE)
-
-create_partitions_from_range(relation       REGCLASS,
-                             attribute      TEXT,
-                             start_value    ANYELEMENT,
-                             end_value      ANYELEMENT,
-                             p_interval     INTERVAL,
-                             partition_data BOOLEAN DEFAULT TRUE)
-```
-Performs RANGE-partitioning from specified range for `relation` by partitioning key `attribute`. Partition creation callback is invoked for each partition if set beforehand.
 
 ### Data migration
 
diff --git a/expected/pathman_basic.out b/expected/pathman_basic.out
@@ -404,50 +404,6 @@ SELECT count(*) FROM test.insert_into_select_copy;
 
 DROP TABLE test.insert_into_select_copy, test.insert_into_select CASCADE;
 NOTICE:  drop cascades to 6 other objects
-/* Test INSERT hooking with DATE type */
-CREATE TABLE test.insert_date_test(val DATE NOT NULL);
-SELECT pathman.create_partitions_from_range('test.insert_date_test', 'val',
-											date '20161001', date '20170101', interval '1 month');
- create_partitions_from_range 
-------------------------------
-                            4
-(1 row)
-
-INSERT INTO test.insert_date_test VALUES ('20161201'); /* just insert the date */
-SELECT count(*) FROM pathman.pathman_partition_list WHERE parent = 'test.insert_date_test'::REGCLASS;
- count 
--------
-     4
-(1 row)
-
-INSERT INTO test.insert_date_test VALUES ('20170311'); /* append new partitions */
-SELECT count(*) FROM pathman.pathman_partition_list WHERE parent = 'test.insert_date_test'::REGCLASS;
- count 
--------
-     6
-(1 row)
-
-INSERT INTO test.insert_date_test VALUES ('20160812'); /* prepend new partitions */
-SELECT count(*) FROM pathman.pathman_partition_list WHERE parent = 'test.insert_date_test'::REGCLASS;
- count 
--------
-     8
-(1 row)
-
-SELECT min(val) FROM test.insert_date_test; /* check first date */
-    min     
-------------
- 08-12-2016
-(1 row)
-
-SELECT max(val) FROM test.insert_date_test; /* check last date */
-    max     
-------------
- 03-11-2017
-(1 row)
-
-DROP TABLE test.insert_date_test CASCADE;
-NOTICE:  drop cascades to 9 other objects
 SET pg_pathman.enable_runtimeappend = OFF;
 SET pg_pathman.enable_runtimemergeappend = OFF;
 VACUUM;
@@ -1527,23 +1483,6 @@ SELECT pathman.split_range_partition('test."RangeRel_1"', '2015-01-01'::DATE);
  {12-31-2014,01-02-2015}
 (1 row)
 
-SELECT pathman.drop_partitions('test."RangeRel"');
-NOTICE:  0 rows copied from test."RangeRel_1"
-NOTICE:  1 rows copied from test."RangeRel_2"
-NOTICE:  1 rows copied from test."RangeRel_3"
-NOTICE:  0 rows copied from test."RangeRel_4"
-NOTICE:  1 rows copied from test."RangeRel_6"
- drop_partitions 
------------------
-               5
-(1 row)
-
-SELECT pathman.create_partitions_from_range('test."RangeRel"', 'dt', '2015-01-01'::DATE, '2015-01-05'::DATE, '1 day'::INTERVAL);
- create_partitions_from_range 
-------------------------------
-                            5
-(1 row)
-
 DROP TABLE test."RangeRel" CASCADE;
 NOTICE:  drop cascades to 6 other objects
 SELECT * FROM pathman.pathman_config;
@@ -1562,21 +1501,6 @@ SELECT pathman.create_range_partitions('test."RangeRel"', 'id', 1, 100, 3);
                        3
 (1 row)
 
-SELECT pathman.drop_partitions('test."RangeRel"');
-NOTICE:  0 rows copied from test."RangeRel_1"
-NOTICE:  0 rows copied from test."RangeRel_2"
-NOTICE:  0 rows copied from test."RangeRel_3"
- drop_partitions 
------------------
-               3
-(1 row)
-
-SELECT pathman.create_partitions_from_range('test."RangeRel"', 'id', 1, 300, 100);
- create_partitions_from_range 
-------------------------------
-                            3
-(1 row)
-
 DROP TABLE test."RangeRel" CASCADE;
 NOTICE:  drop cascades to 4 other objects
 DROP EXTENSION pg_pathman;
@@ -1739,32 +1663,6 @@ NOTICE:  0 rows copied from test.range_rel_15
               14
 (1 row)
 
-SELECT create_partitions_from_range('test.range_rel', 'id', 1, 1000, 100);
- create_partitions_from_range 
-------------------------------
-                           10
-(1 row)
-
-SELECT drop_partitions('test.range_rel', TRUE);
- drop_partitions 
------------------
-              10
-(1 row)
-
-SELECT create_partitions_from_range('test.range_rel', 'dt', '2015-01-01'::date, '2015-12-01'::date, '1 month'::interval);
- create_partitions_from_range 
-------------------------------
-                           12
-(1 row)
-
-EXPLAIN (COSTS OFF) SELECT * FROM test.range_rel WHERE dt = '2015-12-15';
-                                   QUERY PLAN                                   
---------------------------------------------------------------------------------
- Append
-   ->  Seq Scan on range_rel_12
-         Filter: (dt = 'Tue Dec 15 00:00:00 2015'::timestamp without time zone)
-(3 rows)
-
 /* Test NOT operator */
 CREATE TABLE bool_test(a INT NOT NULL, b BOOLEAN);
 SELECT create_hash_partitions('bool_test', 'a', 3);
@@ -1943,6 +1841,6 @@ ORDER BY partition;
 DROP TABLE test.provided_part_names CASCADE;
 NOTICE:  drop cascades to 2 other objects
 DROP SCHEMA test CASCADE;
-NOTICE:  drop cascades to 42 other objects
+NOTICE:  drop cascades to 29 other objects
 DROP EXTENSION pg_pathman CASCADE;
 DROP SCHEMA pathman CASCADE;
diff --git a/expected/pathman_mergejoin_1.out b/expected/pathman_mergejoin_1.out
diff --git a/range.sql b/range.sql
@@ -301,121 +301,6 @@ END
 $$
 LANGUAGE plpgsql;
 
-/*
- * Creates RANGE partitions for specified range
- */
-CREATE OR REPLACE FUNCTION @extschema@.create_partitions_from_range(
-	parent_relid	REGCLASS,
-	expression		TEXT,
-	start_value		ANYELEMENT,
-	end_value		ANYELEMENT,
-	p_interval		ANYELEMENT,
-	partition_data	BOOLEAN DEFAULT TRUE)
-RETURNS INTEGER AS $$
-DECLARE
-	part_count		INTEGER := 0;
-
-BEGIN
-	PERFORM @extschema@.prepare_for_partitioning(parent_relid,
-												 expression,
-												 partition_data);
-
-	/* Check boundaries */
-	PERFORM @extschema@.check_boundaries(parent_relid,
-										 expression,
-										 start_value,
-										 end_value);
-
-	/* Create sequence for child partitions names */
-	PERFORM @extschema@.create_naming_sequence(parent_relid);
-
-	/* Insert new entry to pathman config */
-	PERFORM @extschema@.add_to_pathman_config(parent_relid, expression,
-											  p_interval::TEXT);
-
-	WHILE start_value <= end_value
-	LOOP
-		PERFORM @extschema@.create_single_range_partition(
-			parent_relid,
-			start_value,
-			start_value + p_interval,
-			tablespace := @extschema@.get_tablespace(parent_relid));
-
-		start_value := start_value + p_interval;
-		part_count := part_count + 1;
-	END LOOP;
-
-	/* Relocate data if asked to */
-	IF partition_data = true THEN
-		PERFORM @extschema@.set_enable_parent(parent_relid, false);
-		PERFORM @extschema@.partition_data(parent_relid);
-	ELSE
-		PERFORM @extschema@.set_enable_parent(parent_relid, true);
-	END IF;
-
-	RETURN part_count; /* number of created partitions */
-END
-$$ LANGUAGE plpgsql;
-
-/*
- * Creates RANGE partitions for specified range based on datetime expression
- */
-CREATE OR REPLACE FUNCTION @extschema@.create_partitions_from_range(
-	parent_relid	REGCLASS,
-	expression		TEXT,
-	start_value		ANYELEMENT,
-	end_value		ANYELEMENT,
-	p_interval		INTERVAL,
-	partition_data	BOOLEAN DEFAULT TRUE)
-RETURNS INTEGER AS $$
-DECLARE
-	part_count		INTEGER := 0;
-
-BEGIN
-	PERFORM @extschema@.prepare_for_partitioning(parent_relid,
-												 expression,
-												 partition_data);
-
-	/* Check boundaries */
-	PERFORM @extschema@.check_boundaries(parent_relid,
-										 expression,
-										 start_value,
-										 end_value);
-
-	/* Create sequence for child partitions names */
-	PERFORM @extschema@.create_naming_sequence(parent_relid);
-
-	/* Insert new entry to pathman config */
-	PERFORM @extschema@.add_to_pathman_config(parent_relid, expression,
-											  p_interval::TEXT);
-
-	WHILE start_value <= end_value
-	LOOP
-		EXECUTE
-			format('SELECT @extschema@.create_single_range_partition($1, $2, $3::%s, tablespace:=$4);',
-				   @extschema@.get_base_type(pg_typeof(start_value))::TEXT)
-		USING
-			parent_relid,
-			start_value,
-			start_value + p_interval,
-			@extschema@.get_tablespace(parent_relid);
-
-		start_value := start_value + p_interval;
-		part_count := part_count + 1;
-	END LOOP;
-
-	/* Relocate data if asked to */
-	IF partition_data = true THEN
-		PERFORM @extschema@.set_enable_parent(parent_relid, false);
-		PERFORM @extschema@.partition_data(parent_relid);
-	ELSE
-		PERFORM @extschema@.set_enable_parent(parent_relid, true);
-	END IF;
-
-	RETURN part_count; /* number of created partitions */
-END
-$$ LANGUAGE plpgsql;
-
 
 /*
  * Split RANGE partition
diff --git a/sql/pathman_basic.sql b/sql/pathman_basic.sql
@@ -145,26 +145,6 @@ SELECT count(*) FROM test.insert_into_select_copy;
 DROP TABLE test.insert_into_select_copy, test.insert_into_select CASCADE;
 
 
-/* Test INSERT hooking with DATE type */
-CREATE TABLE test.insert_date_test(val DATE NOT NULL);
-SELECT pathman.create_partitions_from_range('test.insert_date_test', 'val',
-											date '20161001', date '20170101', interval '1 month');
-
-INSERT INTO test.insert_date_test VALUES ('20161201'); /* just insert the date */
-SELECT count(*) FROM pathman.pathman_partition_list WHERE parent = 'test.insert_date_test'::REGCLASS;
-
-INSERT INTO test.insert_date_test VALUES ('20170311'); /* append new partitions */
-SELECT count(*) FROM pathman.pathman_partition_list WHERE parent = 'test.insert_date_test'::REGCLASS;
-
-INSERT INTO test.insert_date_test VALUES ('20160812'); /* prepend new partitions */
-SELECT count(*) FROM pathman.pathman_partition_list WHERE parent = 'test.insert_date_test'::REGCLASS;
-
-SELECT min(val) FROM test.insert_date_test; /* check first date */
-SELECT max(val) FROM test.insert_date_test; /* check last date */
-
-DROP TABLE test.insert_date_test CASCADE;
-
-
 SET pg_pathman.enable_runtimeappend = OFF;
 SET pg_pathman.enable_runtimemergeappend = OFF;
 
@@ -474,17 +454,13 @@ SELECT pathman.append_range_partition('test."RangeRel"');
 SELECT pathman.prepend_range_partition('test."RangeRel"');
 SELECT pathman.merge_range_partitions('test."RangeRel_1"', 'test."RangeRel_' || currval('test."RangeRel_seq"') || '"');
 SELECT pathman.split_range_partition('test."RangeRel_1"', '2015-01-01'::DATE);
-SELECT pathman.drop_partitions('test."RangeRel"');
-SELECT pathman.create_partitions_from_range('test."RangeRel"', 'dt', '2015-01-01'::DATE, '2015-01-05'::DATE, '1 day'::INTERVAL);
 DROP TABLE test."RangeRel" CASCADE;
 SELECT * FROM pathman.pathman_config;
 CREATE TABLE test."RangeRel" (
 	id	SERIAL PRIMARY KEY,
 	dt	TIMESTAMP NOT NULL,
 	txt	TEXT);
 SELECT pathman.create_range_partitions('test."RangeRel"', 'id', 1, 100, 3);
-SELECT pathman.drop_partitions('test."RangeRel"');
-SELECT pathman.create_partitions_from_range('test."RangeRel"', 'id', 1, 300, 100);
 DROP TABLE test."RangeRel" CASCADE;
 
 DROP EXTENSION pg_pathman;
@@ -533,10 +509,6 @@ DELETE FROM test.range_rel r USING test.tmp t WHERE r.dt = '2010-01-02' AND r.id
 
 /* Create range partitions from whole range */
 SELECT drop_partitions('test.range_rel');
-SELECT create_partitions_from_range('test.range_rel', 'id', 1, 1000, 100);
-SELECT drop_partitions('test.range_rel', TRUE);
-SELECT create_partitions_from_range('test.range_rel', 'dt', '2015-01-01'::date, '2015-12-01'::date, '1 month'::interval);
-EXPLAIN (COSTS OFF) SELECT * FROM test.range_rel WHERE dt = '2015-12-15';
 
 /* Test NOT operator */
 CREATE TABLE bool_test(a INT NOT NULL, b BOOLEAN);
