Skip to content

Use new Ark's REPL engine #10661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 27, 2025
Merged

Use new Ark's REPL engine #10661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9dfb0b3
Bump Ark to `feature/read-srcref`
lionel- Nov 7, 2025
c6ec4be
Fix call stack expectations
lionel- Nov 19, 2025
64ad34e
Remove `recover()` test as it's no longer supported
lionel- Nov 20, 2025
c20e365
Bump Ark to 0.1.219
lionel- Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/positron-r/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,7 +928,7 @@
},
"positron": {
"binaryDependencies": {
"ark": "0.1.218"
"ark": "0.1.219"
},
"minimumRVersion": "4.2.0",
"minimumRenvVersion": "1.0.9"
Expand Down
39 changes: 2 additions & 37 deletions test/e2e/tests/debug/r-debug.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ test.describe('R Debugging', {
await debug.expectBrowserModeFrame(1);

// Verify call stack order
await debug.expectCallStackAtIndex(0, 'inner()inner()2:');
await debug.expectCallStackAtIndex(1, 'outer(5)inner(x)2:');
await debug.expectCallStackAtIndex(0, 'inner()inner(x)');
await debug.expectCallStackAtIndex(1, 'outer(5)inner(x)');
await debug.expectCallStackAtIndex(2, '<global>outer(5)');

// Verify the call stack redirects to correct data frame(s)
Expand Down Expand Up @@ -210,40 +210,6 @@ test.describe('R Debugging', {
await executeCode('R', 'fruit_avg(dat, "berry")', { waitForReady: false });
await console.waitForConsoleContents('Found 2 fruits!', { expectedCount: 2 });
});

test('R - Verify debugging with `options(error = recover)` interactive recovery mode', async ({ app, page, openFile, runCommand, executeCode }) => {
const { console } = app.workbench;

await openFile('workspaces/r-debugging/fruit_avg.r');
await runCommand('r.sourceCurrentFile');

// Enable recovery mode so errors trigger the interactive debugger
await executeCode('R', 'options(error = recover)');

// Trigger an error: this should throw an error inside rowMeans(mini_dat)
await executeCode('R', 'fruit_avg(dat, "black")', { waitForReady: false });

// Confirm recovery prompt appears and frame selection is offered
await console.waitForConsoleContents('Enter a frame number, or 0 to exit');
await console.waitForConsoleContents('1: fruit_avg(dat, "black")');

// Select the inner function frame
await console.waitForConsoleContents('Selection:');
await page.keyboard.type('1');
await page.keyboard.press('Enter');

// Confirm error message appears in sidebar
await console.expectConsoleToContainError("'x' must be an array of at least two dimensions");

// Check the contents of mini_dat in the console
await console.focus();
await verifyVariableInConsole(app, 'mini_dat', '[1] 4 9 6');

// Quit the debugger
await page.keyboard.type('Q');
await page.keyboard.press('Enter');
await console.waitForReady('>');
});
});


Expand All @@ -269,4 +235,3 @@ async function verifyVariableInConsole(app: Application, name: string, expectedT
await expect(app.code.driver.page.getByText(expectedText)).toBeVisible({ timeout: 30000 });
});
}

Loading