Skip to content

Conversation

@0xlukem
Copy link
Contributor

@0xlukem 0xlukem commented Nov 13, 2025

πŸ“ Description

This PR adds the icons for remix and hardhat in dev-environments

This PR needs to be merged with this one: papermoonio/polkadot-mkdocs#175

πŸ” Review Preference

Choose one:

  • βœ… I have time to handle formatting/style feedback myself
  • ⚑ Docs team handles formatting (check "Allow edits from maintainers")

πŸ€– AI-Ready Docs

If content changed, regenerate AI files:

  • βœ… I ran python3 scripts/generate_llms.py
  • ⚑ Docs team will regenerate (check "Allow edits from maintainers")

βœ… Checklist

@0xlukem 0xlukem requested a review from a team as a code owner November 13, 2025 17:19
Copilot AI review requested due to automatic review settings November 13, 2025 17:19
@0xlukem 0xlukem added B0 - Needs Review Pull request is ready for review C1 - Medium Medium priority task A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) labels Nov 13, 2025
Copilot finished reviewing on behalf of 0xlukem November 13, 2025 17:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds custom icons to the Remix IDE and Hardhat entries in the dev-environments navigation file to improve visual identification of these development tools.

  • Adds :custom-remix: icon to Remix IDE navigation entry
  • Adds :custom-hardhat: icon to Hardhat navigation entry

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@eshaben
Copy link
Collaborator

eshaben commented Nov 13, 2025

@0xlukem merge conflicts.

But will wait to merge this til the mkdocs PR is ready too

@nhussein11
Copy link
Collaborator

It took me a while to realize that papermoonio/polkadot-mkdocs#175 exists haha. Thanks, @0xlukem; it looks beautiful. Out of curiosity (and not something important), is there an icon we could use for the "local dev node" so that all the pages in the dev environment section have an icon? Or is it okay to leave it blank?

@nhussein11 nhussein11 self-requested a review November 14, 2025 11:19
Copy link
Collaborator

@nhussein11 nhussein11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks!! πŸ™

@kapetan3sid kapetan3sid added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Nov 17, 2025
@eshaben eshaben self-assigned this Nov 18, 2025
@eshaben
Copy link
Collaborator

eshaben commented Nov 18, 2025

@0xlukem the build is failing because it's checking for these icons in the main mkdocs branch. So can you please create a PR to add the icons there too?

@eshaben eshaben merged commit 7a76986 into staging/product-ia Nov 20, 2025
3 of 8 checks passed
@eshaben eshaben deleted the 0xlukem/add-icons branch November 20, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B1 - Ready to Merge Pull request is ready to be merged C1 - Medium Medium priority task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants