hide unsupported properties in sankey more safely

Author: antoinerg

src/plot_api/edit_types.js

@@ -10,7 +10,6 @@
 
 var Lib = require('../lib');
 var extendFlat = Lib.extendFlat;
-var extendDeepAll = Lib.extendDeepAll;
 var isPlainObject = Lib.isPlainObject;
 
 var traceOpts = {
@@ -116,7 +115,7 @@ function falseObj(keys) {
  * @return {object} a new attributes object with `editType` modified as directed
  */
 function overrideAll(attrs, editTypeOverride, overrideContainers) {
-    var out = extendDeepAll({}, attrs);
+    var out = extendFlat({}, attrs);
     for(var key in out) {
         var attr = out[key];
         if(isPlainObject(attr)) {

src/traces/sankey/attributes.js

@@ -17,7 +17,7 @@ var domainAttrs = require('../../plots/domain').attributes;
 var extendFlat = require('../../lib/extend').extendFlat;
 var overrideAll = require('../../plot_api/edit_types').overrideAll;
 
-module.exports = overrideAll({
+var attrs = module.exports = overrideAll({
     domain: domainAttrs({name: 'sankey', trace: true}),
 
     orientation: {
@@ -186,6 +186,7 @@ module.exports = overrideAll({
         hoverlabel: fxAttrs.hoverlabel, // needs editType override,
         description: 'The links of the Sankey plot.'
     },
-    hoverinfo: undefined,
-    hoverlabel: undefined
 }, 'calc', 'nested');
+// hide unsupported top-level properties from plot-schema
+attrs.hoverinfo = undefined;
+attrs.hoverlabel = undefined;