Skip to content

Commit 1813d6c

Browse files
committed
sankey hide unsupported top-level properties from plot-schema
1 parent e942bc5 commit 1813d6c

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/plot_api/edit_types.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
var Lib = require('../lib');
1212
var extendFlat = Lib.extendFlat;
13+
var extendDeepAll = Lib.extendDeepAll;
1314
var isPlainObject = Lib.isPlainObject;
1415

1516
var traceOpts = {
@@ -115,7 +116,7 @@ function falseObj(keys) {
115116
* @return {object} a new attributes object with `editType` modified as directed
116117
*/
117118
function overrideAll(attrs, editTypeOverride, overrideContainers) {
118-
var out = extendFlat({}, attrs);
119+
var out = extendDeepAll({}, attrs);
119120
for(var key in out) {
120121
var attr = out[key];
121122
if(isPlainObject(attr)) {

src/traces/sankey/attributes.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,5 +185,7 @@ module.exports = overrideAll({
185185
hoverinfo: extendFlat({}, plotAttrs.hoverinfo, {flags: []}),
186186
hoverlabel: fxAttrs.hoverlabel, // needs editType override,
187187
description: 'The links of the Sankey plot.'
188-
}
188+
},
189+
hoverinfo: undefined,
190+
hoverlabel: undefined
189191
}, 'calc', 'nested');

0 commit comments

Comments
 (0)