fix funnel bars and connectors as well

Author: archmoj

src/traces/funnel/plot.js

@@ -11,6 +11,7 @@
 var d3 = require('d3');
 var Lib = require('../../lib');
 var Drawing = require('../../components/drawing');
+var BADNUM = require('../../constants/numerical').BADNUM;
 var barPlot = require('../bar/plot');
 var clearMinTextSize = require('../bar/uniform_text').clearMinTextSize;
 
@@ -66,14 +67,21 @@ function plotConnectorRegions(gd, plotinfo, cdModule, traceLayer) {
 
             var shape = '';
 
-            if(x[3] !== undefined && y[3] !== undefined) {
+            if(
+                x[0] !== BADNUM && y[0] !== BADNUM &&
+                x[1] !== BADNUM && y[1] !== BADNUM &&
+                x[2] !== BADNUM && y[2] !== BADNUM &&
+                x[3] !== BADNUM && y[3] !== BADNUM
+            ) {
                 if(isHorizontal) {
                     shape += 'M' + x[0] + ',' + y[1] + 'L' + x[2] + ',' + y[2] + 'H' + x[3] + 'L' + x[1] + ',' + y[1] + 'Z';
                 } else {
                     shape += 'M' + x[1] + ',' + y[1] + 'L' + x[2] + ',' + y[3] + 'V' + y[2] + 'L' + x[1] + ',' + y[0] + 'Z';
                 }
             }
 
+            if(shape === '') shape = 'M0,0Z';
+
             Lib.ensureSingle(d3.select(this), 'path')
                 .attr('d', shape)
                 .call(Drawing.setClipUrl, plotinfo.layerClipId, gd);

test/jasmine/tests/funnel_test.js

@@ -17,6 +17,7 @@ var rgb = color.rgb;
 var customAssertions = require('../assets/custom_assertions');
 var assertHoverLabelContent = customAssertions.assertHoverLabelContent;
 var checkTextTemplate = require('../assets/check_texttemplate');
+var checkTransition = require('../assets/check_transitions');
 var Fx = require('@src/components/fx');
 
 var d3 = require('d3');
@@ -1033,6 +1034,54 @@ describe('A funnel plot', function() {
         .then(done);
     });
 
+    it('handle BADNUM positions', function(done) {
+        var y1 = [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1];
+        var y2 = y1; // no transition now
+        var mockCopy = {
+            data: [
+                {
+                    type: 'funnel',
+                    x: [
+                        0,
+                        1,
+                        '',
+                        'NaN',
+                        NaN,
+                        Infinity,
+                        -Infinity,
+                        undefined,
+                        null,
+                        9,
+                        10
+                    ],
+                    y: y1
+                }
+            ],
+            layout: {
+                width: 400,
+                height: 300
+            }
+        };
+
+        var barTests = [
+            [0, '.point path', 'attr', 'd', ['M12,12V108H12V12Z', 'M12,12V108H23V12Z', 'M120,12V108H120V12Z', 'M120,12V108H120V12Z', 'M120,12V108H120V12Z', 'M120,12V108H120V12Z', 'M120,12V108H120V12Z', 'M120,12V108H120V12Z', 'M120,12V108H120V12Z', 'M23,12V108H120V12Z', 'M120,12V108H228V12Z']]
+        ];
+
+        var connectorTests = [
+            [0, '.regions path', 'attr', 'd', ['M12,108L12,12H23L12,108Z', 'M23,108L120,12H228L120,108Z', 'M0,0Z']]
+        ];
+
+        var animateOpts = {data: [{y: y2}]};
+        var transitionOpts = false; // use default
+
+        checkTransition(gd, mockCopy, animateOpts, transitionOpts, barTests)
+        .then(function() {
+            return checkTransition(gd, mockCopy, animateOpts, transitionOpts, connectorTests);
+        })
+        .catch(failTest)
+        .then(done);
+    });
+
     it('should be able to deal with transform that empty out the data coordinate arrays', function(done) {
         Plotly.plot(gd, {
             data: [{