add test waterfall handle BADNUM positions - can extend the test when transitions are enabled for waterfalls

Author: archmoj

test/jasmine/tests/bar_test.js

@@ -2932,7 +2932,7 @@ describe('bar tweening', function() {
           .then(done);
     });
 
-    it('handle NaN positions on vertical bars', function(done) {
+    it('handle BADNUM positions on vertical bars', function(done) {
         var y1 = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10];
         var y2 = [10, 9, 8, 7, 6, 5, 4, 3, 2, 1];
         var mockCopy = {

test/jasmine/tests/waterfall_test.js

@@ -17,6 +17,7 @@ var rgb = color.rgb;
 var customAssertions = require('../assets/custom_assertions');
 var assertHoverLabelContent = customAssertions.assertHoverLabelContent;
 var checkTextTemplate = require('../assets/check_texttemplate');
+var checkTransition = require('../assets/check_transitions');
 var Fx = require('@src/components/fx');
 
 var d3 = require('d3');
@@ -977,6 +978,54 @@ describe('A waterfall plot', function() {
         .then(done);
     });
 
+    it('handle BADNUM positions', function(done) {
+        var y1 = [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1];
+        var y2 = y1; // no transition now
+        var mockCopy = {
+            data: [
+                {
+                    type: 'waterfall',
+                    x: [
+                        0,
+                        1,
+                        '',
+                        'NaN',
+                        NaN,
+                        Infinity,
+                        -Infinity,
+                        undefined,
+                        null,
+                        9,
+                        10
+                    ],
+                    y: y1
+                }
+            ],
+            layout: {
+                width: 400,
+                height: 300
+            }
+        };
+
+        var barTests = [
+            [0, '.point path', 'attr', 'd', ['M2,121V109H20V121Z', 'M24,111V98H41V111Z', 'M0,0Z', 'M0,0Z', 'M0,0Z', 'M0,0Z', 'M0,0Z', 'M0,0Z', 'M0,0Z', 'M199,28V15H216V28Z', 'M220,17V5H238V17Z']]
+        ];
+
+        var connectorTests = [
+            [0, '.line path', 'attr', 'd', ['M20,110H24', 'M0,0Z', 'M0,0Z', 'M0,0Z', 'M0,0Z', 'M0,0Z', 'M0,0Z', 'M0,0Z', 'M0,0Z', 'M216,16H220', 'M0,0Z']]
+        ];
+
+        var animateOpts = {data: [{y: y2}]};
+        var transitionOpts = false; // use default
+
+        checkTransition(gd, mockCopy, animateOpts, transitionOpts, barTests)
+        .then(function() {
+            return checkTransition(gd, mockCopy, animateOpts, transitionOpts, connectorTests);
+        })
+        .catch(failTest)
+        .then(done);
+    });
+
     it('should be able to deal with transform that empty out the data coordinate arrays', function(done) {
         Plotly.plot(gd, {
             data: [{