-
Notifications
You must be signed in to change notification settings - Fork 20
Implement ListOffsets API #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Implement ListOffsets API #178
Conversation
This change implements `listOffsets` on the admin client. on-behalf-of: @SAP ospo@sap.com
| export type GroupProtocol = keyof typeof GroupProtocols | ||
|
|
||
| // ./consumer/fetch.ts | ||
| export const FetchIsolationLevels = { READ_UNCOMMITTED: 0, READ_COMMITTED: 1 } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert all this renamings.
| additionalProperties: false | ||
| } | ||
|
|
||
| export const adminListOffsetsOptionsSchema = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to listOffsetsOptionsSchema
| partitions: PartitionTimestamp[] | ||
| } | ||
|
|
||
| export interface AdminListOffsetsOptions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use the Admin prefix in these types.
| topics: GroupAssignment[] | ||
| } | ||
|
|
||
| export interface ListOffsetsOptions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this.
| } | ||
|
|
||
| export function runConcurrentCallbacks<ReturnType> ( | ||
| export function runConcurrentCallbacks<ReturnType, Collection extends any[] | Set<any> | Map<any, any>> ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this.
| minBytes: { type: 'number', minimum: 0 }, | ||
| maxBytes: { type: 'number', minimum: 0 }, | ||
| maxWaitTime: { type: 'number', minimum: 0 }, | ||
| isolationLevel: { type: 'string', enum: allowedFetchIsolationLevels }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this.
This change implements
listOffsetson the admin client.on-behalf-of: @SAP ospo@sap.com