Skip to content

Conversation

@lp247
Copy link
Contributor

@lp247 lp247 commented Nov 26, 2025

This change implements listOffsets on the admin client.

on-behalf-of: @SAP ospo@sap.com

This change implements `listOffsets` on the admin client.

on-behalf-of: @SAP ospo@sap.com
export type GroupProtocol = keyof typeof GroupProtocols

// ./consumer/fetch.ts
export const FetchIsolationLevels = { READ_UNCOMMITTED: 0, READ_COMMITTED: 1 }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert all this renamings.

additionalProperties: false
}

export const adminListOffsetsOptionsSchema = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to listOffsetsOptionsSchema

partitions: PartitionTimestamp[]
}

export interface AdminListOffsetsOptions {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use the Admin prefix in these types.

topics: GroupAssignment[]
}

export interface ListOffsetsOptions {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this.

}

export function runConcurrentCallbacks<ReturnType> (
export function runConcurrentCallbacks<ReturnType, Collection extends any[] | Set<any> | Map<any, any>> (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this.

minBytes: { type: 'number', minimum: 0 },
maxBytes: { type: 'number', minimum: 0 },
maxWaitTime: { type: 'number', minimum: 0 },
isolationLevel: { type: 'string', enum: allowedFetchIsolationLevels },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants