Fix 41/NOT_CONTROLLER for non-Kraft clusters #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For non-Kraft clusters requests to create and delete clusters must be sent to the controller broker. Non-controller brokers are answering such requests with error 41/NOT_CONTROLLER. This change ensures that those requests are sent to the correct controller in case we receive error code 41 upon creation or deletion of topics. on-behalf-of: @SAP ospo@sap.com
ShogunPanda
requested changes
Dec 1, 2025
Contributor
ShogunPanda
left a comment
ShogunPanda
left a comment
There was a problem hiding this comment.
The general idea looks fine to me. Few things to fix.
| } | ||
| } | ||
|
|
||
| [kHandleNotControllerError]<T> (error: Error | null, value: T, callback: Callback<T>): void { |
Contributor
There was a problem hiding this comment.
Since this only happens in Admin, move it as private method of Admin.
| retry | ||
| } from '../../helpers.ts' | ||
|
|
||
| process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For non-Kraft clusters, requests to create and delete clusters must be sent to the controller broker. Non-controller brokers are answering such requests with error 41/NOT_CONTROLLER. This change ensures that those requests are sent to the correct controller in case we receive error code 41 upon creating or deleting topics.
on-behalf-of: @SAP ospo@sap.com