Implement Request Timeouts #172
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change implements request timeouts for any request sent to the Kafka cluster. The timeout's duration can be configured via option `requestTimeout` in every client type. Additionally, the retrying logic in the base class is changed so that it retries only if every error in the current error chain is marked as retriable. Otherwise, timeout errors, which should be handled as non-retriable errors, would potentially lead to much longer timeouts due to multiple attempts being made. (But also in general, I would assume that every non-retriable error encountered should block any additional attempt) on-behalf-of: @SAP ospo@sap.com
lp247
force-pushed
the
feature/request_timeouts
branch
from
10601a1 to
305df00
Compare
ShogunPanda
requested changes
Dec 1, 2025
Contributor
ShogunPanda
left a comment
ShogunPanda
left a comment
There was a problem hiding this comment.
Thanks for this, I love the idea.
Few modifications but nothing big.
| } | ||
|
|
||
| get status (): ConnectionStatusValue { | ||
| get status (): ConnectionStatus { |
Contributor
There was a problem hiding this comment.
Why this change (and the types change above)?
| timedOut: false | ||
| } | ||
|
|
||
| this.#requestsQueue.push(fastQueueCallback => { |
Contributor
There was a problem hiding this comment.
Rather than creating two functions here, I would use .bind.
this.#requestsQueue.push(fastQueueCallback => {
request.callback = fastQueueCallback
if (this.#socketMustBeDrained) {
this.#afterDrainRequests.push(request)
return false
}
return this.#sendRequest(request)
}, this.#onResponse.bind(this, request, callback))
And #onResponse (or similar) you clear the timeout and then invoke callback.
Similarly for the setTimeout below:
if (!request.noResponse) {
request.timeoutHandle = setTimeout(this.#onRequestTimeout.bind(this, request), this.#options.requestTimeout)
}
| this.#socket.removeListener('error', connectingSocketErrorHandler) | ||
|
|
||
| this.#socket.on('error', this.#onError.bind(this)) | ||
| this.#socket.on('error', this.#connectedSocketErrorHandler.bind(this)) |
| let mockCount = 1 | ||
| mockAPI(consumer[kConnections], consumerGroupHeartbeatV0.api.key, null, null, () => mockCount-- > 0) | ||
| mockAPI(consumer[kConnections], consumerGroupHeartbeatV0.api.key, null, null, ( | ||
| __originalSend, |
Contributor
There was a problem hiding this comment.
Please only use a single _ in this call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements request timeouts for any request sent to the Kafka cluster. The timeout's duration can be configured via option
requestTimeoutin every client type.Additionally, the retrying logic in the base class is changed so that it retries only if every error in the current error chain is marked as retriable. Otherwise, timeout errors, which should be handled as non-retriable errors, would potentially lead to much longer timeouts due to multiple attempts being made.
(But also in general, I would assume that every non-retriable error encountered should block any additional attempt)
on-behalf-of: @SAP ospo@sap.com