Add: function to add line numbers to block #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calling addLineNumbers
dlesnoff
commented
Nov 10, 2023
| @@ -1,4 +1,4 @@ | |||
| import std / [strutils, tables, sugar, os, strformat, sequtils] | |||
| import std / [strutils, tables, sugar, sequtils] | |||
Contributor
Author
There was a problem hiding this comment.
These are unused imports.
|
|
||
| nbText: """ | ||
| > This nimib document provides a brief description and example for | ||
| > This nimib document provides a brief description and example for |
Contributor
Author
There was a problem hiding this comment.
I'm sorry, the diff contains a lot of line changes because of some automatic tool in my Vim editor to remove whitespaces at the end of lines.
src/nimib/renders.nim
Outdated
Comment on lines
21
to
25
| # result = """ <div> | ||
| # <code>""" & lineNumbers.join("") & """</code> | ||
| # <code>""" & code & """</code> | ||
| # </div> | ||
| # """ |
Contributor
Author
There was a problem hiding this comment.
I think we should wrap the code in a table or a div container so that we can copy-paste code without the numbers.
dlesnoff
changed the title
dlesnoff
changed the title
Contributor
|
Why not use something like https://github.com/wcoder/highlightjs-line-numbers.js? Though I'm not sure about the impact on nimitheme... Using it with this stylesheet works for me: td.hljs-ln-numbers {
text-align: center;
color: #ccc;
vertical-align: top;
padding-right: 5px;
-webkit-touch-callout: none;
-webkit-user-select: none;
-khtml-user-select: none;
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
}
td.hljs-ln-code {
padding-left: 1em;
}
/* Fix for water.css*/
table.hljs-ln {
width: initial;
margin-bottom: 0;
}
table.hljs-ln tbody tr:nth-child(2n) {
background-color: unset;
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not finished yet. Attempt to fix #101.
to do:
I am not satisfied with this generated HTML but at least it renders the numbers correctly.