add Type::isError method #4530
Open
add Type::isError method #4530
+313
−203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Nov 6, 2025
Member
ondrejmirtes
left a comment
ondrejmirtes
left a comment
There was a problem hiding this comment.
ApiInstanceofTypeRule should be made aware of this 😊
canvural
force-pushed
the
is-error
branch
2 times, most recently
from
b940dc5 to
e8922d3
Compare
ondrejmirtes
force-pushed
the
is-error
branch
from
e8922d3 to
2cd5ddf
Compare
Member
|
Do you also feel like doing |
Contributor
Author
Didn't ever need that I guess, but sure I can. In a separate PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one does not add too much value, but I just didn't want to do
instanceof ErrorTypein my extensions 😄