Skip to content

Simplify ConstantArrayTypeBuilder #4529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
Merged

Simplify ConstantArrayTypeBuilder #4529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions src/Type/Constant/ConstantArrayTypeBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
use function is_float;
use function max;
use function min;
use function range;

/**
* @api
Expand Down Expand Up @@ -211,21 +210,13 @@ public function setOffsetValueType(?Type $offsetType, Type $valueType, bool $opt
$integerRanges = TypeUtils::getIntegerRanges($offsetType);
if (count($integerRanges) > 0) {
foreach ($integerRanges as $integerRange) {
if ($integerRange->getMin() === null) {
break;
}
if ($integerRange->getMax() === null) {
break;
}

$rangeLength = $integerRange->getMax() - $integerRange->getMin();
if ($rangeLength >= self::ARRAY_COUNT_LIMIT) {
$scalarTypes = [];
$finiteTypes = $integerRange->getFiniteTypes();
if (count($finiteTypes) === 0) {
break;
}

foreach (range($integerRange->getMin(), $integerRange->getMax()) as $rangeValue) {
$scalarTypes[] = new ConstantIntegerType($rangeValue);
foreach ($finiteTypes as $finiteType) {
$scalarTypes[] = $finiteType;
}
}
}
Expand Down
Loading